chore: worked on making issue list padding consistent (#850)

This commit is contained in:
Kunal Vishwakarma 2023-04-17 15:01:22 +05:30 committed by GitHub
parent 98cef0e1e8
commit 0beb654069
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 38 additions and 30 deletions

View File

@ -388,35 +388,43 @@ export const IssuesView: React.FC<Props> = ({
handleClose={() => setTransferIssuesModal(false)} handleClose={() => setTransferIssuesModal(false)}
isOpen={transferIssuesModal} isOpen={transferIssuesModal}
/> />
<div className="flex items-center justify-between gap-2 -mt-2"> {issueView !== "calendar" && (
<FilterList filters={filters} setFilters={setFilters} /> <div>
{Object.keys(filters).length > 0 && nullFilters.length !== Object.keys(filters).length && ( <div
<PrimaryButton className={`flex items-center justify-between gap-2 ${
onClick={() => { issueView === "list" ? "px-8 mt-6" : "-mt-2"
if (viewId) { }`}
setFilters({}, true);
setToastAlert({
title: "View updated",
message: "Your view has been updated",
type: "success",
});
} else
setCreateViewModal({
query: filters,
});
}}
className="flex items-center gap-2 text-sm"
> >
{!viewId && <PlusIcon className="h-4 w-4" />} <FilterList filters={filters} setFilters={setFilters} />
{viewId ? "Update" : "Save"} view {Object.keys(filters).length > 0 &&
</PrimaryButton> nullFilters.length !== Object.keys(filters).length && (
)} <PrimaryButton
</div> onClick={() => {
if (viewId) {
{Object.keys(filters).length > 0 && nullFilters.length !== Object.keys(filters).length && ( setFilters({}, true);
<div className="my-4 border-t" /> setToastAlert({
title: "View updated",
message: "Your view has been updated",
type: "success",
});
} else
setCreateViewModal({
query: filters,
});
}}
className="flex items-center gap-2 text-sm"
>
{!viewId && <PlusIcon className="h-4 w-4" />}
{viewId ? "Update" : "Save"} view
</PrimaryButton>
)}
</div>
{Object.keys(filters).length > 0 &&
nullFilters.length !== Object.keys(filters).length && (
<div className={` ${issueView === "list" ? "mt-4" : "my-4"} border-t`} />
)}
</div>
)} )}
<DragDropContext onDragEnd={handleOnDragEnd}> <DragDropContext onDragEnd={handleOnDragEnd}>
<StrictModeDroppable droppableId="trashBox"> <StrictModeDroppable droppableId="trashBox">
{(provided, snapshot) => ( {(provided, snapshot) => (

View File

@ -36,7 +36,7 @@ export const AllLists: React.FC<Props> = ({
return ( return (
<> <>
{groupedByIssues && ( {groupedByIssues && (
<div className="flex flex-col space-y-5 gap-4 bg-white"> <div className="flex flex-col space-y-5 bg-white">
{Object.keys(groupedByIssues).map((singleGroup) => { {Object.keys(groupedByIssues).map((singleGroup) => {
const currentState = const currentState =
selectedGroup === "state" ? states?.find((s) => s.id === singleGroup) : null; selectedGroup === "state" ? states?.find((s) => s.id === singleGroup) : null;

View File

@ -216,9 +216,9 @@ export const SingleListIssue: React.FC<Props> = ({
</ContextMenu.Item> </ContextMenu.Item>
</a> </a>
</ContextMenu> </ContextMenu>
<div className="border-b mx-4 border-gray-300 last:border-b-0"> <div className="border-b mx-6 border-gray-300 last:border-b-0">
<div <div
className="flex items-center justify-between gap-2 px-4 py-3" className="flex items-center justify-between gap-2 py-3"
onContextMenu={(e) => { onContextMenu={(e) => {
e.preventDefault(); e.preventDefault();
setContextMenu(true); setContextMenu(true);