github/plane
0
0
Fork 1
mirror of https://github.com/makeplane/plane synced 2024-06-14 14:31:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: estimate order not maintained in create/ update modal. (#3326)

Browse Source 
* fix: estimate order not maintained in create/ update modal.

* fix: estimate points mutation on update.
This commit is contained in:
Prateek Shourya 2024-01-08 16:16:45 +05:30 committed by sriram veeraghanta
parent b62a1b11b1
commit 12a3392722
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
web/components/estimates/estimates-list.tsx
View File

@ -14,6 +14,8 @@ import { EmptyState } from "components/common";
import emptyEstimate from "public/empty-state/estimate.svg"; import emptyEstimate from "public/empty-state/estimate.svg";
// types // types
import { IEstimate } from "@plane/types"; import { IEstimate } from "@plane/types";
// helpers
import { orderArrayBy } from "helpers/array.helper";
export const EstimatesList: React.FC = observer(() => { export const EstimatesList: React.FC = observer(() => {
// states // states
@ -31,7 +33,11 @@ export const EstimatesList: React.FC = observer(() => {
const editEstimate = (estimate: IEstimate) => { const editEstimate = (estimate: IEstimate) => {
setEstimateFormOpen(true); setEstimateFormOpen(true);
setEstimateToUpdate(estimate); // Order the points array by key before updating the estimate to update state
setEstimateToUpdate({
...estimate,
points: orderArrayBy(estimate.points, "key"),
});
}; };
const disableEstimates = () => { const disableEstimates = () => {

2
web/store/estimate.store.ts
View File

@ -172,7 +172,7 @@ export class EstimateStore implements IEstimateStore {
updateEstimate = async (workspaceSlug: string, projectId: string, estimateId: string, data: IEstimateFormData) => updateEstimate = async (workspaceSlug: string, projectId: string, estimateId: string, data: IEstimateFormData) =>
await this.estimateService.patchEstimate(workspaceSlug, projectId, estimateId, data).then((response) => { await this.estimateService.patchEstimate(workspaceSlug, projectId, estimateId, data).then((response) => {
const updatedEstimates = (this.estimates?.[projectId] ?? []).map((estimate) => const updatedEstimates = (this.estimates?.[projectId] ?? []).map((estimate) =>
estimate.id === estimateId ? { ...estimate, ...data.estimate } : estimate estimate.id === estimateId ? { ...estimate, ...data.estimate, points: [...data.estimate_points] } : estimate
); );
runInAction(() => { runInAction(() => {
set(this.estimates, projectId, updatedEstimates); set(this.estimates, projectId, updatedEstimates);