fix: Project Rendering Error in Kanban Layout and Layout Rendering Fixes in Subscribed Profile Issues (#2629)

* fix: rendering projects error in kanabn layout in profile issues and resolved multiplr layout rendering in subscribed profile issues

* fix: implemented spinner loader in profile issues and remove logs in kanban layout
This commit is contained in:
guru_sainath 2023-11-03 13:17:52 +05:30 committed by GitHub
parent dd2ba2ec6f
commit 1352c200dd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 47 additions and 19 deletions

View File

@ -178,8 +178,7 @@ export const KanBan: React.FC<IKanBan> = observer((props) => {
return ( return (
<div className="relative w-full h-full"> <div className="relative w-full h-full">
{/* TODO: have to implement */} {group_by && group_by === "project" && (
{group_by && group_by === "projects" && (
<GroupByKanBan <GroupByKanBan
issues={issues} issues={issues}
group_by={group_by} group_by={group_by}

View File

@ -286,6 +286,28 @@ export const KanBanSwimLanes: React.FC<IKanBanSwimLanes> = observer((props) => {
)} )}
</div> </div>
{sub_group_by && sub_group_by === "project" && (
<SubGroupSwimlane
issues={issues}
sub_group_by={sub_group_by}
group_by={group_by}
list={projects}
listKey={`id`}
handleIssues={handleIssues}
quickActions={quickActions}
displayProperties={displayProperties}
kanBanToggle={kanBanToggle}
handleKanBanToggle={handleKanBanToggle}
showEmptyGroup={showEmptyGroup}
states={states}
stateGroups={stateGroups}
priorities={priorities}
labels={labels}
members={members}
projects={projects}
/>
)}
{sub_group_by && sub_group_by === "state" && ( {sub_group_by && sub_group_by === "state" && (
<SubGroupSwimlane <SubGroupSwimlane
issues={issues} issues={issues}

View File

@ -9,6 +9,7 @@ import { ProfileAuthWrapper } from "layouts/profile-layout";
import { UserProfileHeader } from "components/headers"; import { UserProfileHeader } from "components/headers";
import { ProfileIssuesListLayout } from "components/issues/issue-layouts/list/roots/profile-issues-root"; import { ProfileIssuesListLayout } from "components/issues/issue-layouts/list/roots/profile-issues-root";
import { ProfileIssuesKanBanLayout } from "components/issues/issue-layouts/kanban/roots/profile-issues-root"; import { ProfileIssuesKanBanLayout } from "components/issues/issue-layouts/kanban/roots/profile-issues-root";
import { Spinner } from "@plane/ui";
// hooks // hooks
import { useMobxStore } from "lib/mobx/store-provider"; import { useMobxStore } from "lib/mobx/store-provider";
import { RootStore } from "store/root"; import { RootStore } from "store/root";
@ -46,7 +47,9 @@ const ProfileAssignedIssuesPage: NextPageWithLayout = observer(() => {
return ( return (
<> <>
{isLoading ? ( {isLoading ? (
<div>Loading...</div> <div className="flex justify-center items-center w-full h-full">
<Spinner />
</div>
) : ( ) : (
<div className="w-full h-full relative overflow-auto -z-1"> <div className="w-full h-full relative overflow-auto -z-1">
{activeLayout === "list" ? ( {activeLayout === "list" ? (

View File

@ -11,6 +11,7 @@ import { ProfileAuthWrapper } from "layouts/profile-layout";
import { UserProfileHeader } from "components/headers"; import { UserProfileHeader } from "components/headers";
import { ProfileIssuesListLayout } from "components/issues/issue-layouts/list/roots/profile-issues-root"; import { ProfileIssuesListLayout } from "components/issues/issue-layouts/list/roots/profile-issues-root";
import { ProfileIssuesKanBanLayout } from "components/issues/issue-layouts/kanban/roots/profile-issues-root"; import { ProfileIssuesKanBanLayout } from "components/issues/issue-layouts/kanban/roots/profile-issues-root";
import { Spinner } from "@plane/ui";
// types // types
import { NextPageWithLayout } from "types/app"; import { NextPageWithLayout } from "types/app";
@ -42,7 +43,9 @@ const ProfileCreatedIssuesPage: NextPageWithLayout = () => {
return ( return (
<> <>
{isLoading ? ( {isLoading ? (
<div>Loading...</div> <div className="flex justify-center items-center w-full h-full">
<Spinner />
</div>
) : ( ) : (
<div className="w-full h-full relative overflow-auto -z-1"> <div className="w-full h-full relative overflow-auto -z-1">
{activeLayout === "list" ? ( {activeLayout === "list" ? (

View File

@ -11,6 +11,7 @@ import { ProfileAuthWrapper } from "layouts/profile-layout";
import { UserProfileHeader } from "components/headers"; import { UserProfileHeader } from "components/headers";
import { ProfileIssuesListLayout } from "components/issues/issue-layouts/list/roots/profile-issues-root"; import { ProfileIssuesListLayout } from "components/issues/issue-layouts/list/roots/profile-issues-root";
import { ProfileIssuesKanBanLayout } from "components/issues/issue-layouts/kanban/roots/profile-issues-root"; import { ProfileIssuesKanBanLayout } from "components/issues/issue-layouts/kanban/roots/profile-issues-root";
import { Spinner } from "@plane/ui";
// types // types
import { NextPageWithLayout } from "types/app"; import { NextPageWithLayout } from "types/app";
@ -40,10 +41,11 @@ const ProfileSubscribedIssuesPage: NextPageWithLayout = () => {
const activeLayout = profileIssueFiltersStore.userDisplayFilters.layout; const activeLayout = profileIssueFiltersStore.userDisplayFilters.layout;
return ( return (
<AppLayout header={<UserProfileHeader />}> <>
<ProfileAuthWrapper showProfileIssuesFilter>
{isLoading ? ( {isLoading ? (
<div>Loading...</div> <div className="flex justify-center items-center w-full h-full">
<Spinner />
</div>
) : ( ) : (
<div className="w-full h-full relative overflow-auto -z-1"> <div className="w-full h-full relative overflow-auto -z-1">
{activeLayout === "list" ? ( {activeLayout === "list" ? (
@ -53,8 +55,7 @@ const ProfileSubscribedIssuesPage: NextPageWithLayout = () => {
) : null} ) : null}
</div> </div>
)} )}
</ProfileAuthWrapper> </>
</AppLayout>
); );
}; };