github/plane
0
0
Fork 1
mirror of https://github.com/makeplane/plane synced 2024-06-14 14:31:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: show created by empty for viewers and guests (#1740)

Browse Source 
* chore: show created by empty for viewers and guests

* dev: return empty queryset
This commit is contained in:
Nikhil 2023-08-01 14:16:21 +05:30 committed by GitHub
parent 6e7fa1a39c
commit 1a5faca77c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
apiserver/plane/api/views/notification.py
View File

@ -10,7 +10,7 @@ from plane.utils.paginator import BasePaginator
# Module imports # Module imports
from .base import BaseViewSet, BaseAPIView from .base import BaseViewSet, BaseAPIView
from plane.db.models import Notification, IssueAssignee, IssueSubscriber, Issue from plane.db.models import Notification, IssueAssignee, IssueSubscriber, Issue, WorkspaceMember
from plane.api.serializers import NotificationSerializer from plane.api.serializers import NotificationSerializer
@ -83,10 +83,13 @@ class NotificationViewSet(BaseViewSet, BasePaginator):
# Created issues # Created issues
if type == "created": if type == "created":
issue_ids = Issue.objects.filter( if WorkspaceMember.objects.filter(workspace__slug=slug, member=request.user, role__lt=15).exists():
workspace__slug=slug, created_by=request.user notifications = Notification.objects.none()
).values_list("pk", flat=True) else:
notifications = notifications.filter(entity_identifier__in=issue_ids) issue_ids = Issue.objects.filter(
workspace__slug=slug, created_by=request.user
).values_list("pk", flat=True)
notifications = notifications.filter(entity_identifier__in=issue_ids)
# Pagination # Pagination
if request.GET.get("per_page", False) and request.GET.get("cursor", False): if request.GET.get("per_page", False) and request.GET.get("cursor", False):