diff --git a/apiserver/plane/app/views/oauth.py b/apiserver/plane/app/views/oauth.py index a0eb4973e..de90e4337 100644 --- a/apiserver/plane/app/views/oauth.py +++ b/apiserver/plane/app/views/oauth.py @@ -167,12 +167,6 @@ class OauthEndpoint(BaseAPIView): ] ) - if not GOOGLE_CLIENT_ID or not GITHUB_CLIENT_ID: - return Response( - {"error": "Github or Google login is not configured"}, - status=status.HTTP_400_BAD_REQUEST, - ) - if not medium or not id_token: return Response( { diff --git a/space/components/accounts/github-login-button.tsx b/space/components/accounts/github-sign-in.tsx similarity index 93% rename from space/components/accounts/github-login-button.tsx rename to space/components/accounts/github-sign-in.tsx index 46e4cd18d..322011ae3 100644 --- a/space/components/accounts/github-login-button.tsx +++ b/space/components/accounts/github-sign-in.tsx @@ -8,12 +8,12 @@ import { useTheme } from "next-themes"; import githubBlackImage from "public/logos/github-black.svg"; import githubWhiteImage from "public/logos/github-white.svg"; -export interface GithubLoginButtonProps { +type Props = { handleSignIn: React.Dispatch; clientId: string; -} +}; -export const GithubLoginButton: FC = (props) => { +export const GitHubSignInButton: FC = (props) => { const { handleSignIn, clientId } = props; // states const [loginCallBackURL, setLoginCallBackURL] = useState(undefined); diff --git a/space/components/accounts/google-login.tsx b/space/components/accounts/google-sign-in.tsx similarity index 87% rename from space/components/accounts/google-login.tsx rename to space/components/accounts/google-sign-in.tsx index 707aec919..3d637e949 100644 --- a/space/components/accounts/google-login.tsx +++ b/space/components/accounts/google-sign-in.tsx @@ -1,12 +1,12 @@ import { FC, useEffect, useRef, useCallback, useState } from "react"; import Script from "next/script"; -export interface IGoogleLoginButton { +type Props = { clientId: string; handleSignIn: React.Dispatch; -} +}; -export const GoogleLoginButton: FC = (props) => { +export const GoogleSignInButton: FC = (props) => { const { handleSignIn, clientId } = props; // refs const googleSignInButton = useRef(null); @@ -30,6 +30,7 @@ export const GoogleLoginButton: FC = (props) => { size: "large", logo_alignment: "center", text: "signin_with", + width: 384, } as GsiButtonConfiguration // customization attributes ); } catch (err) { @@ -53,7 +54,7 @@ export const GoogleLoginButton: FC = (props) => { return ( <>