github/plane
0
0
Fork 1
mirror of https://github.com/makeplane/plane synced 2024-06-14 14:31:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: comment text editor user mention validation addded (#4250)

Browse Source
This commit is contained in:
Anmol Singh Bhatia 2024-04-23 13:00:58 +05:30 committed by GitHub
parent ac3def2929
commit 51ade1295c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
space/components/editor/lite-text-editor.tsx
View File

@ -34,10 +34,9 @@ export const LiteTextEditor = React.forwardRef<EditorRefApi, LiteTextEditorWrapp
return !!ref && typeof ref === "object" && "current" in ref; return !!ref && typeof ref === "object" && "current" in ref;
} }
const isEmpty = const isEmpty =
props.initialValue === "" ||
props.initialValue?.trim() === "" || props.initialValue?.trim() === "" ||
props.initialValue === "<p></p>" || props.initialValue === "<p></p>" ||
isEmptyHtmlString(props.initialValue ?? ""); (isEmptyHtmlString(props.initialValue ?? "") && !props.initialValue?.includes("mention-component"));
return ( return (
<div className="border border-custom-border-200 rounded p-3 space-y-3"> <div className="border border-custom-border-200 rounded p-3 space-y-3">

3
web/components/editor/lite-text-editor/lite-text-editor.tsx
View File

@ -59,10 +59,9 @@ export const LiteTextEditor = React.forwardRef<EditorRefApi, LiteTextEditorWrapp
}); });
const isEmpty = const isEmpty =
props.initialValue === "" ||
props.initialValue?.trim() === "" || props.initialValue?.trim() === "" ||
props.initialValue === "<p></p>" || props.initialValue === "<p></p>" ||
isEmptyHtmlString(props.initialValue ?? ""); (isEmptyHtmlString(props.initialValue ?? "") && !props.initialValue?.includes("mention-component"));
function isMutableRefObject<T>(ref: React.ForwardedRef<T>): ref is React.MutableRefObject<T | null> { function isMutableRefObject<T>(ref: React.ForwardedRef<T>): ref is React.MutableRefObject<T | null> {
return !!ref && typeof ref === "object" && "current" in ref; return !!ref && typeof ref === "object" && "current" in ref;