github/plane
0
0
Fork 1
mirror of https://github.com/makeplane/plane synced 2024-06-14 14:31:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

dev: return identifier and also add the validation for state

Browse Source
This commit is contained in:
pablohashescobar 2024-02-01 21:04:34 +05:30
parent 314d4494e5
commit 52c8195181
4 changed files with 76 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
apiserver/plane/api/views/cycle.py
View File

@ -253,9 +253,16 @@ class CycleAPIEndpoint(WebhookMixin, BaseAPIView):
external_id=request.data.get("external_id"),
).exists()
):
cycle = Cycle.objects.filter(
workspace__slug=slug,
project_id=project_id,
external_source=request.data.get("external_source"),
external_id=request.data.get("external_id"),
).first()
return Response(
{
"error": "Cycle with the same external id and external source already exists"
"error": "Cycle with the same external id and external source already exists",
"cycle": str(cycle.id),
},
status=status.HTTP_410_GONE,
)
@ -322,7 +329,8 @@ class CycleAPIEndpoint(WebhookMixin, BaseAPIView):
):
return Response(
{
"error": "Cycle with the same external id and external source already exists"
"error": "Cycle with the same external id and external source already exists",
"cycle_id": str(cycle.id),
},
status=status.HTTP_410_GONE,
)

12
apiserver/plane/api/views/issue.py
View File

@ -230,9 +230,16 @@ class IssueAPIEndpoint(WebhookMixin, BaseAPIView):
external_id=request.data.get("external_id"),
).exists()
):
issue = Issue.objects.filter(
workspace__slug=slug,
project_id=project_id,
external_id=request.data.get("external_id"),
external_source=request.data.get("external_source"),
).first()
return Response(
{
"error": "Issue with the same external id and external source already exists"
"error": "Issue with the same external id and external source already exists",
"issue_id": str(issue.id),
},
status=status.HTTP_410_GONE,
)
@ -290,7 +297,8 @@ class IssueAPIEndpoint(WebhookMixin, BaseAPIView):
):
return Response(
{
"error": "Issue with the same external id and external source already exists"
"error": "Issue with the same external id and external source already exists",
"issue_id": str(issue.id)
},
status=status.HTTP_410_GONE,
)

12
apiserver/plane/api/views/module.py
View File

@ -142,9 +142,16 @@ class ModuleAPIEndpoint(WebhookMixin, BaseAPIView):
external_id=request.data.get("external_id"),
).exists()
):
module = Module.objects.filter(
project_id=project_id,
workspace__slug=slug,
external_source=request.data.get("external_source"),
external_id=request.data.get("external_id"),
).first()
return Response(
{
"error": "Module with the same external id and external source already exists"
"error": "Module with the same external id and external source already exists",
"module_id": str(module.id),
},
status=status.HTTP_410_GONE,
)
@ -182,7 +189,8 @@ class ModuleAPIEndpoint(WebhookMixin, BaseAPIView):
):
return Response(
{
"error": "Module with the same external id and external source already exists"
"error": "Module with the same external id and external source already exists",
"module_id": str(module.id),
},
status=status.HTTP_410_GONE,
)

46
apiserver/plane/api/views/state.py
View File

@ -38,6 +38,30 @@ class StateAPIEndpoint(BaseAPIView):
data=request.data, context={"project_id": project_id}
)
if serializer.is_valid():
if (
request.data.get("external_id")
and request.data.get("external_source")
and State.objects.filter(
project_id=project_id,
workspace__slug=slug,
external_source=request.data.get("external_source"),
external_id=request.data.get("external_id"),
).exists()
):
state = State.objects.filter(
workspace__slug=slug,
project_id=project_id,
external_id=request.data.get("external_id"),
external_source=request.data.get("external_source"),
).first()
return Response(
{
"error": "State with the same external id and external source already exists",
"state_id": str(state.id),
},
status=status.HTTP_410_GONE,
)
serializer.save(project_id=project_id)
return Response(serializer.data, status=status.HTTP_200_OK)
return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST)
@ -91,6 +115,28 @@ class StateAPIEndpoint(BaseAPIView):
)
serializer = StateSerializer(state, data=request.data, partial=True)
if serializer.is_valid():
if (
str(request.data.get("external_id"))
and (state.external_id != str(request.data.get("external_id")))
and request.data.get("external_source")
and (
state.external_source
!= request.data.get("external_source")
)
and Issue.objects.filter(
project_id=project_id,
workspace__slug=slug,
external_source=request.data.get("external_source"),
external_id=request.data.get("external_id"),
).exists()
):
return Response(
{
"error": "Issue with the same external id and external source already exists",
"state_id": str(state.id),
},
status=status.HTTP_410_GONE,
)
serializer.save()
return Response(serializer.data, status=status.HTTP_200_OK)
return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST)