From 6a2be6afc456425744b21911451a6373ed15a600 Mon Sep 17 00:00:00 2001 From: rahulramesha <71900764+rahulramesha@users.noreply.github.com> Date: Wed, 24 Jan 2024 18:50:54 +0530 Subject: [PATCH] fix: archived issues and minor bug fixes (#3451) * make computedFn without optional arguments * fix archived issues * fix activity changes with proper context * fix display filters that require server side filtering --- web/components/core/activity.tsx | 34 +++++++++++++++---- .../activity/actions/estimate.tsx | 2 +- .../issues/issue-detail/main-content.tsx | 3 +- web/components/issues/issue-detail/root.tsx | 5 ++- .../list/roots/archived-issue-root.tsx | 3 ++ .../roots/all-issue-layout-root.tsx | 13 ++++--- .../roots/archived-issue-layout-root.tsx | 18 +++++++--- .../issues/peek-overview/issue-detail.tsx | 1 - web/components/issues/peek-overview/root.tsx | 2 +- web/components/issues/peek-overview/view.tsx | 12 ++----- .../projects/[projectId]/issues/[issueId].tsx | 1 + web/store/estimate.store.ts | 4 +-- web/store/issue/archived/filter.store.ts | 3 ++ web/store/issue/archived/issue.store.ts | 8 +++-- web/store/issue/cycle/filter.store.ts | 5 +++ web/store/issue/draft/filter.store.ts | 3 ++ .../helpers/issue-filter-helper.store.ts | 14 ++++++++ web/store/issue/issue_kanban_view.store.ts | 4 +-- web/store/issue/module/filter.store.ts | 3 ++ web/store/issue/profile/filter.store.ts | 9 +++++ web/store/issue/project-views/filter.store.ts | 3 ++ web/store/issue/project/filter.store.ts | 3 ++ web/store/issue/workspace/filter.store.ts | 4 +++ 23 files changed, 118 insertions(+), 39 deletions(-) diff --git a/web/components/core/activity.tsx b/web/components/core/activity.tsx index 05bc2c6a4..65a2d9831 100644 --- a/web/components/core/activity.tsx +++ b/web/components/core/activity.tsx @@ -94,7 +94,7 @@ const EstimatePoint = observer((props: { point: string }) => { const { areEstimatesEnabledForCurrentProject, getEstimatePointValue } = useEstimate(); const currentPoint = Number(point) + 1; - const estimateValue = getEstimatePointValue(Number(point)); + const estimateValue = getEstimatePointValue(Number(point), null); return ( @@ -142,8 +142,18 @@ const activityDetails: { }, archived_at: { message: (activity) => { - if (activity.new_value === "restore") return "restored the issue."; - else return "archived the issue."; + if (activity.new_value === "restore") + return ( + <> + restored + + ); + else + return ( + <> + archived + + ); }, icon: