refactor: issue details page (#211)

apps/app/pages/[workspaceSlug]/projects/[projectId]/issues/[issueId].tsx

@@ -18,27 +18,17 @@ import AddAsSubIssue from "components/project/issues/issue-detail/add-as-sub-iss
 import IssueDetailSidebar from "components/project/issues/issue-detail/issue-detail-sidebar";
 import AddIssueComment from "components/project/issues/issue-detail/comment/issue-comment-section";
 import IssueActivitySection from "components/project/issues/issue-detail/activity";
-import {
+import { IssueDescriptionForm, SubIssueList, CreateUpdateIssueModal } from "components/issues";
-  IssueDescriptionForm,
-  IssueDescriptionFormValues,
-  SubIssueList,
-  CreateUpdateIssueModal,
-} from "components/issues";
 // ui
-import { Loader, HeaderButton, CustomMenu } from "components/ui";
+import { Loader, CustomMenu } from "components/ui";
 import { Breadcrumbs } from "components/breadcrumbs";
 // icons
-import { ChevronLeftIcon, ChevronRightIcon, PlusIcon } from "@heroicons/react/24/outline";
+import { PlusIcon } from "@heroicons/react/24/outline";
 // types
 import { IIssue } from "types";
 import type { NextPage, NextPageContext } from "next";
 // fetch-keys
-import {
+import { PROJECT_ISSUES_ACTIVITY, ISSUE_DETAILS, SUB_ISSUES } from "constants/fetch-keys";
-  PROJECT_ISSUES_LIST,
-  PROJECT_ISSUES_ACTIVITY,
-  ISSUE_DETAILS,
-  SUB_ISSUES,
-} from "constants/fetch-keys";
 
 const defaultValues = {
   name: "",
@@ -81,15 +71,6 @@ const IssueDetailsPage: NextPage = () => {
       : null
   );
 
-  const { data: issues } = useSWR(
-    workspaceSlug && projectId
-      ? PROJECT_ISSUES_LIST(workspaceSlug as string, projectId as string)
-      : null,
-    workspaceSlug && projectId
-      ? () => issuesService.getIssues(workspaceSlug as string, projectId as string)
-      : null
-  );
-
   const { data: issueActivities, mutate: mutateIssueActivities } = useSWR(
     workspaceSlug && projectId && issueId ? PROJECT_ISSUES_ACTIVITY(issueId as string) : null,
     workspaceSlug && projectId && issueId
@@ -102,17 +83,22 @@ const IssueDetailsPage: NextPage = () => {
       : null
   );
 
+  const { data: siblingIssues } = useSWR(
+    workspaceSlug && projectId && issueDetails?.parent ? SUB_ISSUES(issueDetails.parent) : null,
+    workspaceSlug && projectId && issueDetails?.parent
+      ? () =>
+          issuesService.subIssues(
+            workspaceSlug as string,
+            projectId as string,
+            issueDetails.parent ?? ""
+          )
+      : null
+  );
+
   const { reset, control, watch } = useForm<IIssue>({
     defaultValues,
   });
 
-  const prevIssue = issues?.results[issues?.results.findIndex((issue) => issue.id === issueId) - 1];
-  const nextIssue = issues?.results[issues?.results.findIndex((issue) => issue.id === issueId) + 1];
-
-  const siblingIssues =
-    issueDetails &&
-    issues?.results.filter((i) => i.parent === issueDetails.parent && i.id !== issueId);
-
   useEffect(() => {
     if (issueDetails) {
       mutateIssueActivities();
@@ -191,32 +177,6 @@ const IssueDetailsPage: NextPage = () => {
           />
         </Breadcrumbs>
       }
-      right={
-        <div className="flex items-center gap-2">
-          <HeaderButton
-            Icon={ChevronLeftIcon}
-            label="Previous"
-            className={!prevIssue ? "cursor-not-allowed opacity-70" : ""}
-            onClick={() => {
-              if (!prevIssue) return;
-              router.push(`/${workspaceSlug}/projects/${prevIssue.project}/issues/${prevIssue.id}`);
-            }}
-          />
-          <HeaderButton
-            Icon={ChevronRightIcon}
-            disabled={!nextIssue}
-            label="Next"
-            className={!nextIssue ? "cursor-not-allowed opacity-70" : ""}
-            onClick={() => {
-              if (!nextIssue) return;
-              router.push(
-                `/${workspaceSlug}/projects/${nextIssue.project}/issues/${nextIssue?.id}`
-              );
-            }}
-            position="reverse"
-          />
-        </div>
-      }
     >
       {isOpen && (
         <CreateUpdateIssueModal
@@ -254,19 +214,17 @@ const IssueDetailsPage: NextPage = () => {
                       />
                       <span className="flex-shrink-0 text-gray-600">
                         {issueDetails.project_detail.identifier}-
-                        {issues?.results.find((i) => i.id === issueDetails.parent)?.sequence_id}
+                        {issueDetails.parent_detail?.sequence_id}
                       </span>
                       <span className="truncate font-medium">
-                        {issues?.results
+                        {issueDetails.parent_detail?.name.substring(0, 50)}
-                          .find((i) => i.id === issueDetails.parent)
-                          ?.name.substring(0, 50)}
                       </span>
                     </a>
                   </Link>
 
                   <CustomMenu ellipsis optionsPosition="left">
                     {siblingIssues && siblingIssues.length > 0 ? (
-                      siblingIssues.map((issue) => (
+                      siblingIssues.map((issue: IIssue) => (
                         <CustomMenu.MenuItem key={issue.id}>
                           <Link
                             href={`/${workspaceSlug}/projects/${projectId as string}/issues/${

apps/app/types/issues.d.ts

@@ -50,6 +50,16 @@ export interface IIssueCycle {
   workspace: string;
 }
 
+export interface IIssueParent {
+  description: any;
+  id: string;
+  name: string;
+  priority: string | null;
+  sequence_id: number;
+  start_date: string | null;
+  target_date: string | null;
+}
+
 export interface IIssue {
   assignees: any[] | null;
   assignee_details: IUser[];
@@ -77,7 +87,7 @@ export interface IIssue {
   module: string | null;
   name: string;
   parent: string | null;
-  parent_detail: IProject | null;
+  parent_detail: IIssueParent | null;
   priority: string | null;
   project: string;
   project_detail: IProject;