From 946dddb6b2ddf3a1c0894fac7f3bcfabd7038690 Mon Sep 17 00:00:00 2001 From: Anmol Singh Bhatia <121005188+anmolsinghbhatia@users.noreply.github.com> Date: Thu, 23 Feb 2023 19:04:08 +0530 Subject: [PATCH 1/3] fix: kanban assignees tooltip (#332) --- apps/app/components/core/board-view/single-issue.tsx | 1 + apps/app/components/issues/view-select/assignee.tsx | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/apps/app/components/core/board-view/single-issue.tsx b/apps/app/components/core/board-view/single-issue.tsx index 1e9c4ddd5..b8212ff52 100644 --- a/apps/app/components/core/board-view/single-issue.tsx +++ b/apps/app/components/core/board-view/single-issue.tsx @@ -276,6 +276,7 @@ export const SingleBoardIssue: React.FC = ({ issue={issue} partialUpdateIssue={partialUpdateIssue} isNotAllowed={isNotAllowed} + tooltipPosition="left" /> )} diff --git a/apps/app/components/issues/view-select/assignee.tsx b/apps/app/components/issues/view-select/assignee.tsx index ba7816471..693791ef7 100644 --- a/apps/app/components/issues/view-select/assignee.tsx +++ b/apps/app/components/issues/view-select/assignee.tsx @@ -18,6 +18,7 @@ import { PROJECT_MEMBERS } from "constants/fetch-keys"; type Props = { issue: IIssue; partialUpdateIssue: (formData: Partial) => void; + tooltipPosition?: "left" | "right"; position?: "left" | "right"; isNotAllowed: boolean; }; @@ -25,6 +26,7 @@ type Props = { export const ViewAssigneeSelect: React.FC = ({ issue, partialUpdateIssue, + tooltipPosition = "right", position = "right", isNotAllowed, }) => { @@ -57,7 +59,7 @@ export const ViewAssigneeSelect: React.FC = ({
0 From 443c187cdee7fed0aed13a200db6ed6b839ca2c8 Mon Sep 17 00:00:00 2001 From: Anmol Singh Bhatia <121005188+anmolsinghbhatia@users.noreply.github.com> Date: Thu, 23 Feb 2023 19:54:28 +0530 Subject: [PATCH 2/3] feat: sidebar select option truncate (#334) --- .../issues/sidebar-select/cycle.tsx | 26 ++++++++++++++----- .../issues/sidebar-select/module.tsx | 26 ++++++++++++++----- 2 files changed, 38 insertions(+), 14 deletions(-) diff --git a/apps/app/components/issues/sidebar-select/cycle.tsx b/apps/app/components/issues/sidebar-select/cycle.tsx index b1243fe98..127c78eba 100644 --- a/apps/app/components/issues/sidebar-select/cycle.tsx +++ b/apps/app/components/issues/sidebar-select/cycle.tsx @@ -8,7 +8,7 @@ import useSWR, { mutate } from "swr"; import issuesService from "services/issues.service"; import cyclesService from "services/cycles.service"; // ui -import { Spinner, CustomSelect } from "components/ui"; +import { Spinner, CustomSelect, Tooltip } from "components/ui"; // icons import { CyclesIcon } from "components/icons"; // types @@ -65,11 +65,19 @@ export const SidebarCycleSelect: React.FC = ({
- {issueCycle ? issueCycle.cycle_detail.name : "None"} - + + {issueCycle ? issueCycle.cycle_detail.name : "None"} + + } value={issueCycle?.cycle_detail.id} onChange={(value: any) => { @@ -84,11 +92,15 @@ export const SidebarCycleSelect: React.FC = ({ <> {cycles.map((option) => ( - {option.name} + + {option.name} + ))} - None + + None + ) : ( diff --git a/apps/app/components/issues/sidebar-select/module.tsx b/apps/app/components/issues/sidebar-select/module.tsx index 44bef4d62..90661a0df 100644 --- a/apps/app/components/issues/sidebar-select/module.tsx +++ b/apps/app/components/issues/sidebar-select/module.tsx @@ -7,7 +7,7 @@ import useSWR, { mutate } from "swr"; // services import modulesService from "services/modules.service"; // ui -import { Spinner, CustomSelect } from "components/ui"; +import { Spinner, CustomSelect, Tooltip } from "components/ui"; // icons import { RectangleGroupIcon } from "@heroicons/react/24/outline"; // types @@ -64,11 +64,19 @@ export const SidebarModuleSelect: React.FC = ({
m.id === issueModule?.module)?.name ?? "None"} > - {modules?.find((m) => m.id === issueModule?.module)?.name ?? "None"} - + + {modules?.find((m) => m.id === issueModule?.module)?.name ?? "None"} + + } value={issueModule?.module_detail?.id} onChange={(value: any) => { @@ -83,11 +91,15 @@ export const SidebarModuleSelect: React.FC = ({ <> {modules.map((option) => ( - {option.name} + + {option.name} + ))} - None + + None + ) : ( From b53b0bc3f09eaff0f1ddc2c28cbe6cdf69a57c00 Mon Sep 17 00:00:00 2001 From: Dakshesh Jain <65905942+dakshesh14@users.noreply.github.com> Date: Thu, 23 Feb 2023 19:56:18 +0530 Subject: [PATCH 3/3] fix: create issue modal close on escape click (#333) --- apps/app/components/issues/modal.tsx | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/apps/app/components/issues/modal.tsx b/apps/app/components/issues/modal.tsx index c69faa0eb..28689e6cd 100644 --- a/apps/app/components/issues/modal.tsx +++ b/apps/app/components/issues/modal.tsx @@ -75,6 +75,19 @@ export const CreateUpdateIssueModal: React.FC = ({ setActiveProject(projects?.find((p) => p.id === projectId)?.id ?? projects?.[0].id ?? null); }, [projectId, projects]); + useEffect(() => { + const handleKeyDown = (e: KeyboardEvent) => { + if (e.key === "Escape") { + handleClose(); + } + }; + + window.addEventListener("keydown", handleKeyDown); + return () => { + window.removeEventListener("keydown", handleKeyDown); + }; + }, []); + const addIssueToCycle = async (issueId: string, cycleId: string) => { if (!workspaceSlug || !projectId) return;