github/plane
0
0
Fork 1
mirror of https://github.com/makeplane/plane synced 2024-06-14 14:31:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: bugs & improvements (#2998)

Browse Source 
* fix: create more toggle in update issue modal

* fix: spreadsheet estimate column hide

* fix: flickering in all the layouts

* fix: logs
This commit is contained in:
Lakhan Baheti 2023-12-06 14:29:07 +05:30 committed by sriram veeraghanta
parent be2cf2e842
commit 97bc153ef9
6 changed files with 27 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
web/components/issues/form.tsx
View File

@ -602,6 +602,7 @@ export const IssueForm: FC<IssueFormProps> = observer((props) => {
</div>
</div>
<div className="-mx-5 mt-5 flex items-center justify-between gap-2 border-t border-custom-border-100 px-5 pt-5">
{!status && (
<div
className="flex cursor-default items-center gap-1.5"
onClick={() => setCreateMore((prevData) => !prevData)}
@ -611,7 +612,8 @@ export const IssueForm: FC<IssueFormProps> = observer((props) => {
</div>
<span className="text-xs">Create more</span>
</div>
<div className="flex items-center gap-2">
)}
<div className="flex items-center gap-2 ml-auto">
<Button
variant="neutral-primary"
size="sm"

4
web/components/issues/issue-layouts/roots/all-issue-layout-root.tsx
View File

@ -95,7 +95,7 @@ export const AllIssueLayoutRoot: React.FC<Props> = observer((props) => {
return (
<div className="relative w-full h-full flex flex-col overflow-hidden">
{currentView != currentIssueView && loader === "init-loader" ? (
{currentView != currentIssueView && (loader === "init-loader" || !getIssues) ? (
<div className="w-full h-full flex justify-center items-center">
<Spinner />
</div>
@ -103,7 +103,7 @@ export const AllIssueLayoutRoot: React.FC<Props> = observer((props) => {
<>
<GlobalViewsAppliedFiltersRoot />
{Object.keys(getIssues ?? {}).length == 0 && !loader ? (
{Object.keys(getIssues ?? {}).length == 0 ? (
<>{/* <GlobalViewEmptyState /> */}</>
) : (
<div className="w-full h-full relative overflow-auto">

4
web/components/issues/issue-layouts/roots/cycle-layout-root.tsx
View File

@ -62,13 +62,13 @@ export const CycleLayoutRoot: React.FC = observer(() => {
{cycleStatus === "completed" && <TransferIssues handleClick={() => setTransferIssuesModal(true)} />}
<CycleAppliedFiltersRoot />
{loader === "init-loader" ? (
{loader === "init-loader" || !getIssues ? (
<div className="w-full h-full flex justify-center items-center">
<Spinner />
</div>
) : (
<>
{Object.keys(getIssues ?? {}).length == 0 && !loader ? (
{Object.keys(getIssues ?? {}).length == 0 ? (
<CycleEmptyState workspaceSlug={workspaceSlug} projectId={projectId} cycleId={cycleId} />
) : (
<div className="h-full w-full overflow-auto">

4
web/components/issues/issue-layouts/roots/module-layout-root.tsx
View File

@ -47,13 +47,13 @@ export const ModuleLayoutRoot: React.FC = observer(() => {
<div className="relative w-full h-full flex flex-col overflow-hidden">
<ModuleAppliedFiltersRoot />
{loader === "init-loader" ? (
{loader === "init-loader" || !getIssues ? (
<div className="w-full h-full flex justify-center items-center">
<Spinner />
</div>
) : (
<>
{Object.keys(getIssues ?? {}).length == 0 && !loader ? (
{Object.keys(getIssues ?? {}).length == 0 ? (
<ModuleEmptyState workspaceSlug={workspaceSlug} projectId={projectId} moduleId={moduleId} />
) : (
<div className="h-full w-full overflow-auto">

4
web/components/issues/issue-layouts/roots/project-layout-root.tsx
View File

@ -39,13 +39,13 @@ export const ProjectLayoutRoot: React.FC = observer(() => {
<div className="relative w-full h-full flex flex-col overflow-hidden">
<ProjectAppliedFiltersRoot />
{loader === "init-loader" ? (
{loader === "init-loader" || !getIssues ? (
<div className="w-full h-full flex justify-center items-center">
<Spinner />
</div>
) : (
<>
{Object.keys(getIssues ?? {}).length == 0 && !loader ? (
{Object.keys(getIssues ?? {}).length == 0 ? (
<ProjectEmptyState />
) : (
<div className="w-full h-full relative overflow-auto">

9
web/components/issues/issue-layouts/spreadsheet/columns/columns-list.tsx
View File

@ -1,4 +1,5 @@
import { observer } from "mobx-react-lite";
import { useMobxStore } from "lib/mobx/store-provider";
// components
import { SpreadsheetColumn } from "components/issues";
// types
@ -31,6 +32,12 @@ export const SpreadsheetColumnsList: React.FC<Props> = observer((props) => {
states,
} = props;
const {
project: { currentProjectDetails },
} = useMobxStore();
const isEstimateEnabled: boolean = currentProjectDetails?.estimate !== null;
return (
<>
{displayProperties.state && (
@ -102,7 +109,7 @@ export const SpreadsheetColumnsList: React.FC<Props> = observer((props) => {
property="due_date"
/>
)}
{displayProperties.estimate && (
{displayProperties.estimate && isEstimateEnabled && (
<SpreadsheetColumn
displayFilters={displayFilters}
disableUserActions={disableUserActions}