From b60237b6760d9155a011e788285705342b9aab43 Mon Sep 17 00:00:00 2001
From: Ankush Deshmukh <ankush25d@gmail.com>
Date: Tue, 14 Nov 2023 20:52:43 +0530
Subject: [PATCH] Standarding priority icons across the platform (#2776)

---
 packages/ui/src/icons/priority-icon.tsx       | 38 +++++++++++----
 packages/ui/src/icons/type.d.ts               |  1 +
 web/components/inbox/issue-card.tsx           | 14 ------
 .../filters/header/filters/priority.tsx       | 48 ++-----------------
 .../issue-layouts/kanban/headers/priority.tsx | 33 ++-----------
 .../issues/sidebar-select/priority.tsx        |  8 ++--
 web/components/project/priority-select.tsx    | 18 ++-----
 7 files changed, 46 insertions(+), 114 deletions(-)

diff --git a/packages/ui/src/icons/priority-icon.tsx b/packages/ui/src/icons/priority-icon.tsx
index 2c2e012e9..7d7f02694 100644
--- a/packages/ui/src/icons/priority-icon.tsx
+++ b/packages/ui/src/icons/priority-icon.tsx
@@ -15,24 +15,42 @@ import { IPriorityIcon } from "./type";
 export const PriorityIcon: React.FC<IPriorityIcon> = ({
   priority,
   className = "",
+  transparentBg = false
 }) => {
-  if (!className || className === "") className = "h-3.5 w-3.5";
+  if (!className || className === "") className = "h-4 w-4";
 
   // Convert to lowercase for string comparison
   const lowercasePriority = priority?.toLowerCase();
 
+  //get priority icon
+  const getPriorityIcon = (): React.ReactNode => {
+    switch (lowercasePriority) {
+      case 'urgent':
+        return <AlertCircle className={`text-red-500 ${ transparentBg ? '' : 'p-0.5' } ${className}`} />;
+      case 'high':
+        return <SignalHigh className={`text-orange-500 ${ transparentBg ? '' : 'pl-1' } ${className}`} />;
+      case 'medium':
+        return <SignalMedium className={`text-yellow-500 ${ transparentBg ? '' : 'ml-1.5' } ${className}`} />;
+      case 'low':
+        return <SignalLow className={`text-green-500 ${ transparentBg ? '' : 'ml-2' } ${className}`} />;
+      default:
+        return <Ban className={`text-custom-text-200 ${ transparentBg ? '' : 'p-0.5' } ${className}`} />;
+    }
+  };
+
   return (
     <>
-      {lowercasePriority === "urgent" ? (
-        <AlertCircle className={`text-red-500 ${className}`} />
-      ) : lowercasePriority === "high" ? (
-        <SignalHigh className={`text-orange-500 ${className}`} />
-      ) : lowercasePriority === "medium" ? (
-        <SignalMedium className={`text-yellow-500 ${className}`} />
-      ) : lowercasePriority === "low" ? (
-        <SignalLow className={`text-green-500 ${className}`} />
+      { transparentBg ? (
+        getPriorityIcon()
       ) : (
-        <Ban className={`text-custom-text-200 ${className}`} />
+        <div className={`grid h-5 w-5 place-items-center rounded border items-center ${
+          lowercasePriority === "urgent"
+            ? "border-red-500/20 bg-red-500/20"
+            : "border-custom-border-200"
+          }`}
+        >
+          { getPriorityIcon() }
+        </div>
       )}
     </>
   );
diff --git a/packages/ui/src/icons/type.d.ts b/packages/ui/src/icons/type.d.ts
index 0261ab163..65b188e4c 100644
--- a/packages/ui/src/icons/type.d.ts
+++ b/packages/ui/src/icons/type.d.ts
@@ -7,4 +7,5 @@ export type TIssuePriorities = "urgent" | "high" | "medium" | "low" | "none";
 export interface IPriorityIcon {
   priority: TIssuePriorities | null;
   className?: string;
+  transparentBg?: boolean | false;
 }
diff --git a/web/components/inbox/issue-card.tsx b/web/components/inbox/issue-card.tsx
index 56f6b6dcc..47080e367 100644
--- a/web/components/inbox/issue-card.tsx
+++ b/web/components/inbox/issue-card.tsx
@@ -42,21 +42,7 @@ export const InboxIssueCard: React.FC<Props> = (props) => {
           </div>
           <div className="flex items-center gap-2 flex-wrap">
             <Tooltip tooltipHeading="Priority" tooltipContent={`${issue.priority ?? "None"}`}>
-              <div
-                className={`grid h-6 w-6 place-items-center rounded border items-center shadow-sm ${
-                  issue.priority === "urgent"
-                    ? "border-red-500/20 bg-red-500/20"
-                    : issue.priority === "high"
-                    ? "border-orange-500/20 bg-orange-500/20"
-                    : issue.priority === "medium"
-                    ? "border-yellow-500/20 bg-yellow-500/20"
-                    : issue.priority === "low"
-                    ? "border-green-500/20 bg-green-500/20"
-                    : "border-custom-border-200"
-                }`}
-              >
                 <PriorityIcon priority={issue.priority ?? null} className="h-3.5 w-3.5" />
-              </div>
             </Tooltip>
             <Tooltip
               tooltipHeading="Created on"
diff --git a/web/components/issues/issue-layouts/filters/header/filters/priority.tsx b/web/components/issues/issue-layouts/filters/header/filters/priority.tsx
index 660897100..f6b5afd8e 100644
--- a/web/components/issues/issue-layouts/filters/header/filters/priority.tsx
+++ b/web/components/issues/issue-layouts/filters/header/filters/priority.tsx
@@ -1,53 +1,15 @@
 import React, { useState } from "react";
 import { observer } from "mobx-react-lite";
 
+// ui
+import { PriorityIcon } from "@plane/ui";
+
 // components
 import { FilterHeader, FilterOption } from "components/issues";
-// icons
-import { AlertCircle, SignalHigh, SignalMedium, SignalLow, Ban } from "lucide-react";
+
 // constants
 import { ISSUE_PRIORITIES } from "constants/issue";
 
-const PriorityIcons = ({
-  priority,
-  size = 12,
-  strokeWidth = 1.5,
-}: {
-  priority: string;
-  size?: number;
-  strokeWidth?: number;
-}) => {
-  if (priority === "urgent")
-    return (
-      <div className="flex-shrink-0 rounded-sm overflow-hidden w-5 h-5 border border-red-500 bg-red-500 text-white flex justify-center items-center">
-        <AlertCircle size={size} strokeWidth={strokeWidth} />
-      </div>
-    );
-  if (priority === "high")
-    return (
-      <div className="flex-shrink-0 rounded-sm overflow-hidden w-5 h-5 border border-custom-border-200 text-red-500 flex justify-center items-center pl-1">
-        <SignalHigh size={size} strokeWidth={strokeWidth} />
-      </div>
-    );
-  if (priority === "medium")
-    return (
-      <div className="flex-shrink-0 rounded-sm overflow-hidden w-5 h-5 border border-custom-border-200 text-orange-500 flex justify-center items-center pl-1">
-        <SignalMedium size={size} strokeWidth={strokeWidth} />
-      </div>
-    );
-  if (priority === "low")
-    return (
-      <div className="flex-shrink-0 rounded-sm overflow-hidden w-5 h-5 border border-custom-border-200 text-green-500 flex justify-center items-center pl-1">
-        <SignalLow size={size} strokeWidth={strokeWidth} />
-      </div>
-    );
-  return (
-    <div className="flex-shrink-0 rounded-sm overflow-hidden w-5 h-5 border border-custom-border-200 text-custom-text-400 flex justify-center items-center">
-      <Ban size={size} strokeWidth={strokeWidth} />
-    </div>
-  );
-};
-
 type Props = {
   appliedFilters: string[] | null;
   handleUpdate: (val: string) => void;
@@ -78,7 +40,7 @@ export const FilterPriority: React.FC<Props> = observer((props) => {
                 key={priority.key}
                 isChecked={appliedFilters?.includes(priority.key) ? true : false}
                 onClick={() => handleUpdate(priority.key)}
-                icon={<PriorityIcons priority={priority.key} />}
+                icon={<PriorityIcon priority={priority.key} className="h-3.5 w-3.5" />}
                 title={priority.title}
               />
             ))
diff --git a/web/components/issues/issue-layouts/kanban/headers/priority.tsx b/web/components/issues/issue-layouts/kanban/headers/priority.tsx
index 57fe6cd07..fea41dbeb 100644
--- a/web/components/issues/issue-layouts/kanban/headers/priority.tsx
+++ b/web/components/issues/issue-layouts/kanban/headers/priority.tsx
@@ -5,6 +5,9 @@ import { AlertCircle, SignalHigh, SignalMedium, SignalLow, Ban } from "lucide-re
 import { HeaderGroupByCard } from "./group-by-card";
 import { HeaderSubGroupByCard } from "./sub-group-by-card";
 
+// Icons
+import { PriorityIcon } from "@plane/ui";
+
 export interface IPriorityHeader {
   column_id: string;
   column_value: any;
@@ -16,32 +19,6 @@ export interface IPriorityHeader {
   handleKanBanToggle: any;
 }
 
-const Icon = ({ priority }: any) => (
-  <div className="w-full h-full">
-    {priority === "urgent" ? (
-      <div className="border border-red-500 bg-red-500 text-white w-full h-full overflow-hidden flex justify-center items-center rounded-sm">
-        <AlertCircle size={14} strokeWidth={2} />
-      </div>
-    ) : priority === "high" ? (
-      <div className="border border-red-500/20 bg-red-500/10 text-red-500 w-full h-full overflow-hidden flex justify-center items-center rounded-sm">
-        <SignalHigh size={14} strokeWidth={2} className="pl-[3px]" />
-      </div>
-    ) : priority === "medium" ? (
-      <div className="border border-orange-500/20 bg-orange-500/10 text-orange-500 w-full h-full overflow-hidden flex justify-center items-center rounded-sm">
-        <SignalMedium size={14} strokeWidth={2} className="pl-[3px]" />
-      </div>
-    ) : priority === "low" ? (
-      <div className="border border-green-500/20 bg-green-500/10 text-green-500 w-full h-full overflow-hidden flex justify-center items-center rounded-sm">
-        <SignalLow size={14} strokeWidth={2} className="pl-[3px]" />
-      </div>
-    ) : (
-      <div className="border border-custom-border-400/20 bg-custom-text-400/10 text-custom-text-400 w-full h-full overflow-hidden flex justify-center items-center rounded-sm">
-        <Ban size={14} strokeWidth={2} />
-      </div>
-    )}
-  </div>
-);
-
 export const PriorityHeader: FC<IPriorityHeader> = observer((props) => {
   const {
     column_id,
@@ -62,7 +39,7 @@ export const PriorityHeader: FC<IPriorityHeader> = observer((props) => {
         (sub_group_by && header_type === "sub_group_by" ? (
           <HeaderSubGroupByCard
             column_id={column_id}
-            icon={<Icon priority={priority?.key} />}
+            icon={<PriorityIcon priority={priority?.key} />}
             title={priority?.title || ""}
             count={issues_count}
             kanBanToggle={kanBanToggle}
@@ -73,7 +50,7 @@ export const PriorityHeader: FC<IPriorityHeader> = observer((props) => {
             sub_group_by={sub_group_by}
             group_by={group_by}
             column_id={column_id}
-            icon={<Icon priority={priority?.key} />}
+            icon={<PriorityIcon priority={priority?.key} />}
             title={priority?.title || ""}
             count={issues_count}
             kanBanToggle={kanBanToggle}
diff --git a/web/components/issues/sidebar-select/priority.tsx b/web/components/issues/sidebar-select/priority.tsx
index 3d36acabc..e6f142e6e 100644
--- a/web/components/issues/sidebar-select/priority.tsx
+++ b/web/components/issues/sidebar-select/priority.tsx
@@ -17,7 +17,7 @@ export const SidebarPrioritySelect: React.FC<Props> = ({ value, onChange, disabl
   <CustomSelect
     customButton={
       <div
-        className={`flex items-center gap-1.5 text-left text-xs capitalize rounded px-2.5 py-0.5 ${
+        className={`flex items-center gap-1 text-left text-xs capitalize rounded px-2 py-0.5 ${
           value === "urgent"
             ? "border-red-500/20 bg-red-500/20 text-red-500"
             : value === "high"
@@ -29,8 +29,8 @@ export const SidebarPrioritySelect: React.FC<Props> = ({ value, onChange, disabl
             : "bg-custom-background-80 border-custom-border-200 text-custom-text-200"
         }`}
       >
-        <span className="grid place-items-center -my-1">
-          <PriorityIcon priority={value} className="h-3.5 w-3.5" />
+        <span className="flex items-center justify-center h-4 w-4 overflow-hidden">
+          <PriorityIcon priority={value} transparentBg={true} className={`w-3.5 h-3.5 ${(value === "urgent" || value === "none") ? 'p-0.5' : '-mt-1'} `} />
         </span>
         <span>{value ?? "None"}</span>
       </div>
@@ -43,7 +43,7 @@ export const SidebarPrioritySelect: React.FC<Props> = ({ value, onChange, disabl
     {PRIORITIES.map((option) => (
       <CustomSelect.Option key={option} value={option} className="capitalize">
         <>
-          <PriorityIcon priority={option} className="h-3.5 w-3.5" />
+          <PriorityIcon priority={option} />
           {option ?? "None"}
         </>
       </CustomSelect.Option>
diff --git a/web/components/project/priority-select.tsx b/web/components/project/priority-select.tsx
index 9c12e6433..b2bf4413b 100644
--- a/web/components/project/priority-select.tsx
+++ b/web/components/project/priority-select.tsx
@@ -32,7 +32,7 @@ export const PrioritySelect: React.FC<Props> = ({
   optionsClassName = "",
   placement,
   showTitle = false,
-  highlightUrgentPriority = true,
+  //highlightUrgentPriority = true,
   hideDropdownArrow = false,
   disabled = false,
 }) => {
@@ -74,7 +74,7 @@ export const PrioritySelect: React.FC<Props> = ({
       <div className="flex items-center gap-2">
         <PriorityIcon
           priority={value}
-          className={`h-3.5 w-3.5 ${value === "urgent" ? (highlightUrgentPriority ? "text-white" : "text-red-500") : ""}`}
+          className={`h-3.5 w-3.5`}
         />
         {showTitle && <span className="capitalize text-xs">{value}</span>}
       </div>
@@ -93,19 +93,7 @@ export const PrioritySelect: React.FC<Props> = ({
         <button
           ref={setReferenceElement}
           type="button"
-          className={`flex items-center justify-between gap-1 h-full w-full text-xs rounded border-[0.5px] ${
-            value === "urgent"
-              ? highlightUrgentPriority
-                ? "border-red-500/20 bg-red-500"
-                : "border-custom-border-300"
-              : "border-custom-border-300"
-          } ${
-            !disabled
-              ? `${
-                  value === "urgent" && highlightUrgentPriority ? "hover:bg-red-400" : "hover:bg-custom-background-80"
-                }`
-              : ""
-          } ${disabled ? "cursor-not-allowed text-custom-text-200" : "cursor-pointer"} ${buttonClassName}`}
+          className={`flex items-center justify-between gap-1 h-full w-full !p-0 ${disabled ? "cursor-not-allowed text-custom-text-200" : "cursor-pointer"} ${buttonClassName}`}
         >
           {label}
           {!hideDropdownArrow && !disabled && <ChevronDown className="h-2.5 w-2.5" aria-hidden="true" />}