github/plane
0
0
Fork 1
mirror of https://github.com/makeplane/plane synced 2024-06-14 14:31:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: removing the issue from the issue root store while we are deleting from the issue bulk delete modal (#3470)

Browse Source
This commit is contained in:
guru_sainath 2024-01-25 16:37:59 +05:30 committed by GitHub
parent ec3cad1f25
commit c1c2a6ddce
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 27 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
web/components/core/modals/bulk-delete-issues-modal.tsx
View File

@ -17,9 +17,11 @@ import { IUser, TIssue } from "@plane/types";
// fetch keys
import { PROJECT_ISSUES_LIST } from "constants/fetch-keys";
// store hooks
import { useProject } from "hooks/store";
import { useIssues, useProject } from "hooks/store";
// components
import { BulkDeleteIssuesModalItem } from "./bulk-delete-issues-modal-item";
// constants
import { EIssuesStoreType } from "constants/issue";
type FormInput = {
delete_issue_ids: string[];
@ -40,6 +42,9 @@ export const BulkDeleteIssuesModal: React.FC<Props> = observer((props) => {
const { workspaceSlug, projectId } = router.query;
// hooks
const { getProjectById } = useProject();
const {
issues: { removeBulkIssues },
} = useIssues(EIssuesStoreType.PROJECT);
// states
const [query, setQuery] = useState("");
// fetching project issues.
@ -82,17 +87,13 @@ export const BulkDeleteIssuesModal: React.FC<Props> = observer((props) => {
if (!Array.isArray(data.delete_issue_ids)) data.delete_issue_ids = [data.delete_issue_ids];
await issueService
.bulkDeleteIssues(workspaceSlug as string, projectId as string, {
issue_ids: data.delete_issue_ids,
})
await removeBulkIssues(workspaceSlug as string, projectId as string, data.delete_issue_ids)
.then(() => {
setToastAlert({
type: "success",
title: "Success!",
message: "Issues deleted successfully!",
});
handleClose();
})
.catch(() =>

20
web/store/issue/project/issue.store.ts
View File

@ -24,6 +24,7 @@ export interface IProjectIssues {
updateIssue: (workspaceSlug: string, projectId: string, issueId: string, data: Partial<TIssue>) => Promise<TIssue>;
removeIssue: (workspaceSlug: string, projectId: string, issueId: string) => Promise<TIssue>;
quickAddIssue: (workspaceSlug: string, projectId: string, data: TIssue) => Promise<TIssue>;
removeBulkIssues: (workspaceSlug: string, projectId: string, issueIds: string[]) => Promise<void>;
}
export class ProjectIssues extends IssueHelperStore implements IProjectIssues {
@ -53,6 +54,7 @@ export class ProjectIssues extends IssueHelperStore implements IProjectIssues {
createIssue: action,
updateIssue: action,
removeIssue: action,
removeBulkIssues: action,
quickAddIssue: action,
});
// root store
@ -185,4 +187,22 @@ export class ProjectIssues extends IssueHelperStore implements IProjectIssues {
throw error;
}
};
removeBulkIssues = async (workspaceSlug: string, projectId: string, issueIds: string[]) => {
try {
runInAction(() => {
issueIds.forEach((issueId) => {
pull(this.issues[projectId], issueId);
this.rootStore.issues.removeIssue(issueId);
});
});
const response = await this.issueService.bulkDeleteIssues(workspaceSlug, projectId, { issue_ids: issueIds });
return response;
} catch (error) {
this.fetchIssues(workspaceSlug, projectId, "mutation");
throw error;
}
};
}

2
web/store/issue/workspace/filter.store.ts
View File

@ -164,8 +164,6 @@ export class WorkspaceIssuesFilter extends IssueFilterHelperStore implements IWo
if (!viewId) throw new Error("View id is required");
const issueFilters = this.getIssueFilters(viewId);
console.log("issueFilters", issueFilters);
if (!issueFilters || isEmpty(filters)) return;
const _filters = {