fix: assignee and labels field while editing an issue (#296)

* fix: assignee and labels field while editing an issue

* chore: remove unused declarations
This commit is contained in:
Aaryan Khandelwal 2023-02-17 19:07:36 +05:30 committed by GitHub
parent a0d176c952
commit c979599e53
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 20 additions and 45 deletions

View File

@ -117,6 +117,8 @@ export const IssueForm: FC<IssueFormProps> = ({
...defaultValues, ...defaultValues,
...initialData, ...initialData,
project: projectId, project: projectId,
assignees_list: initialData?.assignees ?? [],
labels_list: initialData?.labels ?? [],
}); });
}, [initialData, reset, projectId]); }, [initialData, reset, projectId]);
@ -276,13 +278,6 @@ export const IssueForm: FC<IssueFormProps> = ({
<IssuePrioritySelect value={value} onChange={onChange} /> <IssuePrioritySelect value={value} onChange={onChange} />
)} )}
/> />
<Controller
control={control}
name="assignees_list"
render={({ field: { value, onChange } }) => (
<IssueAssigneeSelect projectId={projectId} value={value} onChange={onChange} />
)}
/>
<Controller <Controller
control={control} control={control}
name="labels_list" name="labels_list"
@ -308,6 +303,13 @@ export const IssueForm: FC<IssueFormProps> = ({
)} )}
/> />
</div> </div>
<Controller
control={control}
name="assignees_list"
render={({ field: { value, onChange } }) => (
<IssueAssigneeSelect projectId={projectId} value={value} onChange={onChange} />
)}
/>
<IssueParentSelect <IssueParentSelect
control={control} control={control}
isOpen={parentIssueListModalOpen} isOpen={parentIssueListModalOpen}

View File

@ -4,8 +4,6 @@ import { useRouter } from "next/router";
import useSWR, { mutate } from "swr"; import useSWR, { mutate } from "swr";
// react-hook-form
import { useForm } from "react-hook-form";
// headless ui // headless ui
import { Dialog, Transition } from "@headlessui/react"; import { Dialog, Transition } from "@headlessui/react";
// services // services
@ -72,11 +70,6 @@ export const CreateUpdateIssueModal: React.FC<IssuesModalProps> = ({
workspaceSlug ? () => projectService.getProjects(workspaceSlug as string) : null workspaceSlug ? () => projectService.getProjects(workspaceSlug as string) : null
); );
const { setError } = useForm<IIssue>({
mode: "all",
reValidateMode: "onChange",
});
useEffect(() => { useEffect(() => {
if (projects && projects.length > 0) if (projects && projects.length > 0)
setActiveProject(projects?.find((p) => p.id === projectId)?.id ?? projects?.[0].id ?? null); setActiveProject(projects?.find((p) => p.id === projectId)?.id ?? projects?.[0].id ?? null);

View File

@ -9,9 +9,7 @@ import { Transition, Combobox } from "@headlessui/react";
// services // services
import projectServices from "services/project.service"; import projectServices from "services/project.service";
// ui // ui
import { Avatar } from "components/ui"; import { AssigneesList, Avatar } from "components/ui";
// icons
import { UserIcon } from "@heroicons/react/24/outline";
// fetch keys // fetch keys
import { PROJECT_MEMBERS } from "constants/fetch-keys"; import { PROJECT_MEMBERS } from "constants/fetch-keys";
@ -63,22 +61,10 @@ export const IssueAssigneeSelect: FC<IssueAssigneeSelectProps> = ({
> >
{({ open }: any) => ( {({ open }: any) => (
<> <>
<Combobox.Label className="sr-only">Assignees</Combobox.Label> <Combobox.Button className="flex items-center cursor-pointer gap-1 rounded-md">
<Combobox.Button <div className="flex items-center gap-1 text-xs">
className={`flex cursor-pointer items-center gap-1 rounded-md border px-2 py-1 text-xs shadow-sm duration-300 hover:bg-gray-100 focus:border-indigo-500 focus:outline-none focus:ring-1 focus:ring-indigo-500`} {value && Array.isArray(value) ? <AssigneesList userIds={value} length={10} /> : null}
> </div>
<UserIcon className="h-3 w-3 text-gray-500" />
<span
className={`hidden truncate sm:block ${
value === null || value === undefined ? "" : "text-gray-900"
}`}
>
{Array.isArray(value)
? value
.map((v) => options?.find((option) => option.value === v)?.display)
.join(", ") || "Assignees"
: options?.find((option) => option.value === value)?.display || "Assignees"}
</span>
</Combobox.Button> </Combobox.Button>
<Transition <Transition

View File

@ -66,17 +66,11 @@ export const SidebarAssigneeSelect: React.FC<Props> = ({ control, submitChanges,
isNotAllowed ? "cursor-not-allowed" : "cursor-pointer" isNotAllowed ? "cursor-not-allowed" : "cursor-pointer"
} items-center gap-1 text-xs`} } items-center gap-1 text-xs`}
> >
<span <div className="flex items-center gap-1 text-xs">
className={`hidden truncate text-left sm:block ${ {value && Array.isArray(value) ? (
value ? "" : "text-gray-900" <AssigneesList userIds={value} length={10} />
}`} ) : null}
> </div>
<div className="flex items-center gap-1 text-xs">
{value && Array.isArray(value) ? (
<AssigneesList userIds={value} length={10} />
) : null}
</div>
</span>
</Listbox.Button> </Listbox.Button>
<Transition <Transition

View File

@ -66,7 +66,7 @@ export interface IIssueLink {
} }
export interface IIssue { export interface IIssue {
assignees: any[] | null; assignees: string[] | null;
assignee_details: IUser[]; assignee_details: IUser[];
assignees_list: string[]; assignees_list: string[];
attachments: any[]; attachments: any[];