github/plane
0
0
Fork 1
mirror of https://github.com/makeplane/plane synced 2024-06-14 14:31:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: error message for jira importers (#794)

Browse Source
This commit is contained in:
pablohashescobar 2023-04-13 00:34:53 +05:30 committed by GitHub
parent c4609b95cd
commit cd69b06e5e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 23 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
apiserver/plane/api/views/importer.py
View File

@ -65,27 +65,33 @@ class ServiceIssueImportSummaryEndpoint(BaseAPIView):
) )
if service == "jira": if service == "jira":
# Check for all the keys
params = {
"project_key": "Project key is required",
"api_token": "API token is required",
"email": "Email is required",
"cloud_hostname": "Cloud hostname is required",
}
for key, error_message in params.items():
if not request.GET.get(key, False):
return Response(
{"error": error_message}, status=status.HTTP_400_BAD_REQUEST
)
project_key = request.GET.get("project_key", "") project_key = request.GET.get("project_key", "")
api_token = request.GET.get("api_token", "") api_token = request.GET.get("api_token", "")
email = request.GET.get("email", "") email = request.GET.get("email", "")
cloud_hostname = request.GET.get("cloud_hostname", "") cloud_hostname = request.GET.get("cloud_hostname", "")
if (
not bool(project_key)
or not bool(api_token)
or not bool(email)
or not bool(cloud_hostname)
):
return Response(
{
"error": "Project name, Project key, API token, Cloud hostname and email are requied"
},
status=status.HTTP_400_BAD_REQUEST,
)
return Response( response = jira_project_issue_summary(
jira_project_issue_summary(
email, api_token, project_key, cloud_hostname email, api_token, project_key, cloud_hostname
), )
if "error" in response:
return Response(response, status=status.HTTP_400_BAD_REQUEST)
else:
return Response(
response,
status=status.HTTP_200_OK, status=status.HTTP_200_OK,
) )
return Response( return Response(