Virtualization like changes for spreadsheet

This commit is contained in:
rahulramesha 2024-02-01 18:49:58 +05:30
parent 08487fb7d4
commit ff14d037c6
3 changed files with 96 additions and 92 deletions

View File

@ -97,17 +97,15 @@ export const SpreadsheetIssueRow = observer((props: Props) => {
return ( return (
<> <>
<tr
className={cn({
"border border-custom-primary-70 hover:border-custom-primary-70": peekIssue?.issueId === issueDetail.id,
})}
>
{/* first column/ issue name and key column */} {/* first column/ issue name and key column */}
<td <td
className={cn( className={cn(
"sticky group left-0 h-11 w-[28rem] flex items-center bg-custom-background-100 text-sm after:absolute border-r-[0.5px] border-custom-border-200", "sticky group left-0 h-11 w-[28rem] flex items-center bg-custom-background-100 text-sm after:absolute border-r-[0.5px] border-custom-border-200",
{ {
"border-b-[0.5px]": peekIssue?.issueId !== issueDetail.id, "border-b-[0.5px]": peekIssue?.issueId !== issueDetail.id,
},
{
"border border-custom-primary-70 hover:border-custom-primary-70": peekIssue?.issueId === issueDetail.id,
} }
)} )}
> >
@ -183,7 +181,6 @@ export const SpreadsheetIssueRow = observer((props: Props) => {
</WithDisplayPropertiesHOC> </WithDisplayPropertiesHOC>
); );
})} })}
</tr>
{isExpanded && {isExpanded &&
subIssues && subIssues &&

View File

@ -5,6 +5,9 @@ import { EIssueActions } from "../types";
//components //components
import { SpreadsheetIssueRow } from "./issue-row"; import { SpreadsheetIssueRow } from "./issue-row";
import { SpreadsheetHeader } from "./spreadsheet-header"; import { SpreadsheetHeader } from "./spreadsheet-header";
import { MutableRefObject, useRef } from "react";
import RenderIfVisible from "components/core/render-if-visible-HOC";
import { cn } from "helpers/common.helper";
type Props = { type Props = {
displayProperties: IIssueDisplayProperties; displayProperties: IIssueDisplayProperties;
@ -20,6 +23,7 @@ type Props = {
handleIssues: (issue: TIssue, action: EIssueActions) => Promise<void>; handleIssues: (issue: TIssue, action: EIssueActions) => Promise<void>;
canEditProperties: (projectId: string | undefined) => boolean; canEditProperties: (projectId: string | undefined) => boolean;
portalElement: React.MutableRefObject<HTMLDivElement | null>; portalElement: React.MutableRefObject<HTMLDivElement | null>;
containerRef: MutableRefObject<HTMLTableElement | null>;
}; };
export const SpreadsheetTable = observer((props: Props) => { export const SpreadsheetTable = observer((props: Props) => {
@ -33,6 +37,7 @@ export const SpreadsheetTable = observer((props: Props) => {
quickActions, quickActions,
handleIssues, handleIssues,
canEditProperties, canEditProperties,
containerRef,
} = props; } = props;
return ( return (
@ -45,8 +50,8 @@ export const SpreadsheetTable = observer((props: Props) => {
/> />
<tbody> <tbody>
{issueIds.map((id) => ( {issueIds.map((id) => (
<RenderIfVisible key={id} as="tr" defaultHeight={44.5} root={containerRef}>
<SpreadsheetIssueRow <SpreadsheetIssueRow
key={id}
issueId={id} issueId={id}
displayProperties={displayProperties} displayProperties={displayProperties}
quickActions={quickActions} quickActions={quickActions}
@ -56,6 +61,7 @@ export const SpreadsheetTable = observer((props: Props) => {
handleIssues={handleIssues} handleIssues={handleIssues}
portalElement={portalElement} portalElement={portalElement}
/> />
</RenderIfVisible>
))} ))}
</tbody> </tbody>
</table> </table>

View File

@ -112,6 +112,7 @@ export const SpreadsheetView: React.FC<Props> = observer((props) => {
quickActions={quickActions} quickActions={quickActions}
handleIssues={handleIssues} handleIssues={handleIssues}
canEditProperties={canEditProperties} canEditProperties={canEditProperties}
containerRef={containerRef}
/> />
</div> </div>
<div className="border-t border-custom-border-100"> <div className="border-t border-custom-border-100">