plane/packages/editor/core
M. Palanikannan 0b1efb173f [refactor] Editor code refactoring (#3194)
* removed relative imports from editor core

* Update issue widget file paths and imports to use kebab case instead of camel case, to align with coding conventions and improve consistency.

* Update Tiptap core and extensions versions to 2.1.13 and Tiptap React version to 2.1.13. Update Tiptap table imports to use the new location in package @tiptap/pm/tables. Update AlertLabel component to use the new type definition for LucideIcon.

* updated lock file

* removed default exports from editor/core

* fixed injecting css into the core package itself

* seperated css code to have single source of origin wrt to the package

* removed default imports from document editor

* all instances using index as key while mapping fixed

* Update Lite Text Editor package.json to remove @plane/editor-types as a dependency.

Update Lite Text Editor index.ts to update the import of IMentionSuggestion and IMentionHighlight from @plane/editor-types to @plane/editor-core.

Update Lite Text Editor ui/index.tsx to update the import of UploadImage, DeleteImage, IMentionSuggestion, and RestoreImage from @plane/editor-types to @plane/editor-core.

Update Lite Text Editor ui/menus/fixed-menu/index.tsx to update the import of UploadImage from @plane/editor-types to @plane/editor-core.

Update turbo.json to remove @plane/editor-types#build as a dependency for @plane/lite-text-editor#build, @plane/rich-text-editor#build, and @plane/document-editor#build.

* Remove deprecated import and adjust tippy.js usage in the slash-commands.tsx file of the editor extensions package.

* Update dependencies in `rich-text-editor/package.json`, remove `@plane/editor-types` and add `@plane/editor-core` in `rich-text-editor/src/index.ts`, and update imports in `rich-text-editor/src/ui/extensions/index.tsx` and `rich-text-editor/src/ui/index.tsx` to use `@plane/editor-core` instead of `@plane/editor-types`.

* Update package.json dependencies and add new types for image deletion, upload, restore, mention highlight, mention suggestion, and slash command item.

* Update import statements in various files to use the new package "@plane/editor-core" instead of "@plane/editor-types".

* fixed document editor to follow conventions

* Refactor imports in the Rich Text Editor package to use relative paths instead of absolute paths.

- Updated imports in `index.ts`, `ui/index.tsx`, and `ui/menus/bubble-menu/index.tsx` to use relative paths.
- Updated `tsconfig.json` to include the `baseUrl` compiler option and adjust the `include` and `exclude` paths.

* Refactor Lite Text Editor code to use relative import paths instead of absolute import paths.

* Added LucideIconType to the exports in index.ts for use in other files.
Created a new file lucide-icon.ts which contains the type LucideIconType.
Updated the icon type in HeadingOneItem in menu-items/index.tsx to use LucideIconType.
Updated the Icon type in AlertLabel in alert-label.tsx to use LucideIconType.
Updated the Icon type in VerticalDropdownItemProps in vertical-dropdown-menu.tsx to use LucideIconType.
Updated the Icon type in BubbleMenuItem in fixed-menu/index.tsx to use LucideIconType.
Deleted the file tooltip.tsx since it is no longer used.
Updated the Icon type in BubbleMenuItem in bubble-menu/index.tsx to use LucideIconType.

* ♻️ refactor: simplify rendering logic in slash-commands.tsx

The rendering logic in the file "slash-commands.tsx" has been simplified. Previously, the code used inline positioning for the popup, but it has now been removed. Instead of appending the popup to the document body, it is now appended to the element with the ID "tiptap-container". The "flip" option has also been removed. These changes have improved the readability and maintainability of the code.

* fixed build errors caused due to core's internal imports

* regression: fixed pages not saving issue and not duplicating with proper content issue

* build: Update @tiptap dependencies

Updated the @tiptap dependencies in the package.json files of `document-editor`, `extensions`, and `rich-text-editor` packages to version 2.1.13.

* 🚑 fix: Correct appendTo selector in slash-commands.tsx

Update the `appendTo` function call in `slash-commands.tsx` to use the correct selector `#editor-container` instead of `#tiptap-container`. This ensures that the component is appended to the appropriate container in the editor extension.

Note: The commit message assumes that the change is a fix for an issue or error. If it's not a fix, please provide more context so that an appropriate commit type can be determined.
2023-12-22 18:10:18 +05:30
..
src [refactor] Editor code refactoring (#3194) 2023-12-22 18:10:18 +05:30
.eslintrc.js chore: format all files in monorepo (#3054) 2023-12-10 15:48:10 +05:30
.prettierignore chore: format all files in monorepo (#3054) 2023-12-10 15:48:10 +05:30
.prettierrc chore: format all files in monorepo (#3054) 2023-12-10 15:48:10 +05:30
package.json [refactor] Editor code refactoring (#3194) 2023-12-22 18:10:18 +05:30
postcss.config.js feat: Editor Core Packaging and Restructuring (#2358) 2023-10-13 12:05:49 +05:30
Readme.md fix: project states fixes (#2731) 2023-11-08 20:31:46 +05:30
tailwind.config.js feat: Editor Core Packaging and Restructuring (#2358) 2023-10-13 12:05:49 +05:30
tsconfig.json [refactor] Editor code refactoring (#3194) 2023-12-22 18:10:18 +05:30
tsup.config.ts feat: Editor Core Packaging and Restructuring (#2358) 2023-10-13 12:05:49 +05:30

@plane/editor-core

Description

The @plane/editor-core package serves as the foundation for our editor system. It provides the base functionality for our other editor packages, but it will not be used directly in any of the projects but only for extending other editors.

Utilities

We provide a wide range of utilities for extending the core itself.

  1. Merging classes and custom styling
  2. Adding new extensions
  3. Adding custom props
  4. Base menu items, and their commands

This allows for extensive customization and flexibility in the Editors created using our editor-core package.

Here's a detailed overview of what's exported

  1. useEditor - A hook that you can use to extend the Plane editor.

    Prop Type Description
    extensions Extension[] An array of custom extensions you want to add into the editor to extend it's core features
    editorProps EditorProps Extend the editor props by passing in a custom props object
    uploadFile (file: File) => Promise<string> A function that handles file upload. It takes a file as input and handles the process of uploading that file.
    deleteFile (assetUrlWithWorkspaceId: string) => Promise<any> A function that handles deleting an image. It takes the asset url from your bucket and handles the process of deleting that image.
    value html string The initial content of the editor.
    debouncedUpdatesEnabled boolean If set to true, the onChange event handler is debounced, meaning it will only be invoked after the specified delay (default 1500ms) once the user has stopped typing.
    onChange (json: any, html: string) => void This function is invoked whenever the content of the editor changes. It is passed the new content in both JSON and HTML formats.
    setIsSubmitting (isSubmitting: "submitting" | "submitted" | "saved") => void This function is called to update the submission status.
    setShouldShowAlert (showAlert: boolean) => void This function is used to show or hide an alert in case of content not being "saved".
    forwardedRef any Pass this in whenever you want to control the editor's state from an external component
  2. useReadOnlyEditor - A hook that can be used to extend a Read Only instance of the core editor.

    Prop Type Description
    value string The initial content of the editor.
    forwardedRef any Pass this in whenever you want to control the editor's state from an external component
    extensions Extension[] An array of custom extensions you want to add into the editor to extend it's core features
    editorProps EditorProps Extend the editor props by passing in a custom props object
  3. Items and Commands - H1, H2, H3, task list, quote, code block, etc's methods.

  4. UI Wrappers

  • EditorContainer - Wrap your Editor Container with this to apply base classes and styles.
  • EditorContentWrapper - Use this to get Editor's Content and base menus.
  1. Extending with Custom Styles
const customEditorClassNames = getEditorClassNames({
  noBorder,
  borderOnFocus,
  customClassName,
});

Core features

  • Content Trimming: The Editors content is now automatically trimmed of empty line breaks from the start and end before submitting it to the backend. This ensures cleaner, more consistent data.
  • Value Cleaning: The Editors value is cleaned at the editor core level, eliminating the need for additional validation before sending from our app. This results in cleaner code and less potential for errors.
  • Turbo Pipeline: Added a turbo pipeline for both dev and build tasks for projects depending on the editor package.
    "web#develop": {
      "cache": false,
      "persistent": true,
      "dependsOn": [
        "@plane/lite-text-editor#build",
        "@plane/rich-text-editor#build"
      ]
    },
    "space#develop": {
      "cache": false,
      "persistent": true,
      "dependsOn": [
        "@plane/lite-text-editor#build",
        "@plane/rich-text-editor#build"
      ]
    },
    "web#build": {
      "cache": true,
      "dependsOn": [
        "@plane/lite-text-editor#build",
        "@plane/rich-text-editor#build"
      ]
    },
    "space#build": {
      "cache": true,
      "dependsOn": [
        "@plane/lite-text-editor#build",
        "@plane/rich-text-editor#build"
      ]
    },

Base extensions included

  • BulletList
  • OrderedList
  • Blockquote
  • Code
  • Gapcursor
  • Link
  • Image
  • Basic Marks
    • Underline
    • TextStyle
    • Color
  • TaskList
  • Markdown
  • Table