mirror of
https://github.com/makeplane/plane
synced 2024-06-14 14:31:34 +00:00
5c089f0223
* fix: issue comment empty string and on enter functionality * fix: empty html tag validation added * fix: purifying dom contents before saving comments --------- Co-authored-by: sriram veeraghanta <veeraghanta.sriram@gmail.com>
131 lines
4.0 KiB
TypeScript
131 lines
4.0 KiB
TypeScript
import { FC, useRef } from "react";
|
|
import { useForm, Controller } from "react-hook-form";
|
|
// components
|
|
import { LiteTextEditorWithRef } from "@plane/lite-text-editor";
|
|
import { Button } from "@plane/ui";
|
|
// services
|
|
import { FileService } from "services/file.service";
|
|
// types
|
|
import { TActivityOperations } from "../root";
|
|
import { TIssueComment } from "@plane/types";
|
|
// icons
|
|
import { Globe2, Lock } from "lucide-react";
|
|
import { useMention, useWorkspace } from "hooks/store";
|
|
// helpers
|
|
import { isEmptyHtmlString } from "helpers/string.helper";
|
|
|
|
const fileService = new FileService();
|
|
|
|
type TIssueCommentCreate = {
|
|
workspaceSlug: string;
|
|
activityOperations: TActivityOperations;
|
|
showAccessSpecifier?: boolean;
|
|
};
|
|
|
|
type commentAccessType = {
|
|
icon: any;
|
|
key: string;
|
|
label: "Private" | "Public";
|
|
};
|
|
const commentAccess: commentAccessType[] = [
|
|
{
|
|
icon: Lock,
|
|
key: "INTERNAL",
|
|
label: "Private",
|
|
},
|
|
{
|
|
icon: Globe2,
|
|
key: "EXTERNAL",
|
|
label: "Public",
|
|
},
|
|
];
|
|
|
|
export const IssueCommentCreate: FC<TIssueCommentCreate> = (props) => {
|
|
const { workspaceSlug, activityOperations, showAccessSpecifier = false } = props;
|
|
const workspaceStore = useWorkspace();
|
|
const workspaceId = workspaceStore.getWorkspaceBySlug(workspaceSlug as string)?.id as string;
|
|
|
|
const { mentionHighlights, mentionSuggestions } = useMention();
|
|
|
|
// refs
|
|
const editorRef = useRef<any>(null);
|
|
// react hook form
|
|
const {
|
|
handleSubmit,
|
|
control,
|
|
watch,
|
|
formState: { isSubmitting },
|
|
reset,
|
|
} = useForm<Partial<TIssueComment>>({ defaultValues: { comment_html: "<p></p>" } });
|
|
|
|
const onSubmit = async (formData: Partial<TIssueComment>) => {
|
|
await activityOperations.createComment(formData).finally(() => {
|
|
reset({ comment_html: "" });
|
|
editorRef.current?.clearEditor();
|
|
});
|
|
};
|
|
|
|
const isEmpty =
|
|
watch("comment_html") === "" ||
|
|
watch("comment_html")?.trim() === "" ||
|
|
watch("comment_html") === "<p></p>" ||
|
|
isEmptyHtmlString(watch("comment_html") ?? "");
|
|
|
|
return (
|
|
<div
|
|
onKeyDown={(e) => {
|
|
if (e.key === "Enter" && !e.shiftKey && !isEmpty) {
|
|
handleSubmit(onSubmit)(e);
|
|
}
|
|
}}
|
|
>
|
|
<Controller
|
|
name="access"
|
|
control={control}
|
|
render={({ field: { onChange: onAccessChange, value: accessValue } }) => (
|
|
<Controller
|
|
name="comment_html"
|
|
control={control}
|
|
render={({ field: { value, onChange } }) => (
|
|
<LiteTextEditorWithRef
|
|
cancelUploadImage={fileService.cancelUpload}
|
|
uploadFile={fileService.getUploadFileFunction(workspaceSlug as string)}
|
|
deleteFile={fileService.getDeleteImageFunction(workspaceId)}
|
|
restoreFile={fileService.getRestoreImageFunction(workspaceId)}
|
|
ref={editorRef}
|
|
value={!value ? "<p></p>" : value}
|
|
customClassName="p-2"
|
|
editorContentCustomClassNames="min-h-[35px]"
|
|
debouncedUpdatesEnabled={false}
|
|
onChange={(comment_json: Object, comment_html: string) => {
|
|
onChange(comment_html);
|
|
}}
|
|
mentionSuggestions={mentionSuggestions}
|
|
mentionHighlights={mentionHighlights}
|
|
commentAccessSpecifier={
|
|
showAccessSpecifier
|
|
? { accessValue: accessValue ?? "INTERNAL", onAccessChange, showAccessSpecifier, commentAccess }
|
|
: undefined
|
|
}
|
|
submitButton={
|
|
<Button
|
|
disabled={isSubmitting || isEmpty}
|
|
variant="primary"
|
|
type="submit"
|
|
className="!px-2.5 !py-1.5 !text-xs"
|
|
onClick={(e) => {
|
|
handleSubmit(onSubmit)(e);
|
|
}}
|
|
>
|
|
{isSubmitting ? "Adding..." : "Comment"}
|
|
</Button>
|
|
}
|
|
/>
|
|
)}
|
|
/>
|
|
)}
|
|
/>
|
|
</div>
|
|
);
|
|
};
|