<titledata-rh="true">Contributing | Puppeteer</title><metadata-rh="true"name="viewport"content="width=device-width,initial-scale=1"><metadata-rh="true"name="twitter:card"content="summary_large_image"><metadata-rh="true"property="og:url"content="https://pptr.dev/contributing"><metadata-rh="true"property="og:locale"content="en"><metadata-rh="true"name="docsearch:language"content="en"><metadata-rh="true"name="docsearch:counter"content="2"><metadata-rh="true"property="og:title"content="Contributing | Puppeteer"><metadata-rh="true"name="description"content="First of all, thank you for your interest in Puppeteer! We'd love to accept your"><metadata-rh="true"property="og:description"content="First of all, thank you for your interest in Puppeteer! We'd love to accept your"><linkdata-rh="true"rel="icon"href="/img/favicon.ico"><linkdata-rh="true"rel="canonical"href="https://pptr.dev/contributing"><linkdata-rh="true"rel="alternate"href="https://pptr.dev/contributing"hreflang="en"><linkdata-rh="true"rel="alternate"href="https://pptr.dev/contributing"hreflang="x-default"><linkdata-rh="true"rel="preconnect"href="https://DVKY664LG7-dsn.algolia.net"crossorigin="anonymous"><linkrel="search"type="application/opensearchdescription+xml"title="Puppeteer"href="/opensearch.xml">
<h2class="anchor anchorWithStickyNavbar_FNw8"id="contributor-license-agreement">Contributor License Agreement<aclass="hash-link"aria-label="Direct link to Contributor License Agreement"title="Direct link to Contributor License Agreement"href="/contributing#contributor-license-agreement"></a></h2>
part of the project. Head over to <<ahref="https://cla.developers.google.com/"target="_blank"rel="noopener noreferrer">https://cla.developers.google.com/</a>> to see
your current agreements on file or to sign a new one.</p>
<p>You generally only need to submit a CLA once, so if you've already submitted one
<h2class="anchor anchorWithStickyNavbar_FNw8"id="getting-started">Getting started<aclass="hash-link"aria-label="Direct link to Getting started"title="Direct link to Getting started"href="/contributing#getting-started"></a></h2>
<p><ahref="https://github.com/codespaces/new?hide_repo_select=true&ref=main&repo=90796663&machine=standardLinux32gb&devcontainer_path=.devcontainer%2Fdevcontainer.json"target="_blank"rel="noopener noreferrer"><imgdecoding="async"loading="lazy"src="https://github.com/codespaces/badge.svg"alt="Open in GitHub Codespaces"class="img_wQsy"></a></p>
<h2class="anchor anchorWithStickyNavbar_FNw8"id="building-a-single-package">Building a single package<aclass="hash-link"aria-label="Direct link to Building a single package"title="Direct link to Building a single package"href="/contributing#building-a-single-package"></a></h2>
<h3class="anchor anchorWithStickyNavbar_FNw8"id="watch-mode">Watch mode<aclass="hash-link"aria-label="Direct link to Watch mode"title="Direct link to Watch mode"href="/contributing#watch-mode"></a></h3>
<h2class="anchor anchorWithStickyNavbar_FNw8"id="removing-stale-artifacts">Removing stale artifacts<aclass="hash-link"aria-label="Direct link to Removing stale artifacts"title="Direct link to Removing stale artifacts"href="/contributing#removing-stale-artifacts"></a></h2>
<h2class="anchor anchorWithStickyNavbar_FNw8"id="comprehensive-testing">Comprehensive testing<aclass="hash-link"aria-label="Direct link to Comprehensive testing"title="Direct link to Comprehensive testing"href="/contributing#comprehensive-testing"></a></h2>
<h3class="anchor anchorWithStickyNavbar_FNw8"id="unit-tests">Unit tests<aclass="hash-link"aria-label="Direct link to Unit tests"title="Direct link to Unit tests"href="/contributing#unit-tests"></a></h3>
<h2class="anchor anchorWithStickyNavbar_FNw8"id="code-reviews">Code reviews<aclass="hash-link"aria-label="Direct link to Code reviews"title="Direct link to Code reviews"href="/contributing#code-reviews"></a></h2>
<h2class="anchor anchorWithStickyNavbar_FNw8"id="code-style">Code Style<aclass="hash-link"aria-label="Direct link to Code Style"title="Direct link to Code Style"href="/contributing#code-style"></a></h2>
<h2class="anchor anchorWithStickyNavbar_FNw8"id="project-structure">Project structure<aclass="hash-link"aria-label="Direct link to Project structure"title="Direct link to Project structure"href="/contributing#project-structure"></a></h2>
<h2class="anchor anchorWithStickyNavbar_FNw8"id="api-guidelines">API guidelines<aclass="hash-link"aria-label="Direct link to API guidelines"title="Direct link to API guidelines"href="/contributing#api-guidelines"></a></h2>
<h2class="anchor anchorWithStickyNavbar_FNw8"id="commit-messages">Commit messages<aclass="hash-link"aria-label="Direct link to Commit messages"title="Direct link to Commit messages"href="/contributing#commit-messages"></a></h2>
<divclass="codeBlockContainer_aalF theme-code-block"style="--prism-color:#393A34;--prism-background-color:#f6f8fa"><divclass="codeBlockContent_MHx8"><pretabindex="0"class="prism-code language-text codeBlock_zHgq thin-scrollbar"style="color:#393A34;background-color:#f6f8fa"><codeclass="codeBlockLines_RjmQ"><spanclass="token-line"style="color:#393A34"><spanclass="token plain">fix(page): fix page.pizza method</span><br></span><spanclass="token-line"style="color:#393A34"><spanclass="token plain"style="display:inline-block"></span><br></span><spanclass="token-line"style="color:#393A34"><spanclass="token plain">This patch fixes page.pizza so that it works with iframes.</span><br></span><spanclass="token-line"style="color:#393A34"><spanclass="token plain"style="display:inline-block"></span><br></span><spanclass="token-line"style="color:#393A34"><spanclass="token plain">Issues: #123, #234</span><br></span><spanclass="token-line"style="color:#393A34"><spanclass="token plain"style="display:inline-block"></span><br></span><spanclass="token-line"style="color:#393A34"><spanclass="token plain">BREAKING CHANGE: page.pizza now delivers pizza at home by default.</span><br></span><spanclass="token-line"style="color:#393A34"><spanclass="token plain">To deliver to a different location, use the "deliver" option:</span><br></span><spanclass="token-line"style="color:#393A34"><spanclass="token plain"> `page.pizza({deliver: 'work'})`.</span><br></span></code></pre><divclass="buttonGroup_Sd8_"><buttontype="button"aria-label="Copy code to clipboard"title="Copy"class="clean-btn"><spanclass="copyButtonIcons_LnQD"aria-hidden="true"><svgviewBox="0 0 24 24"class="copyButtonIcon_t3l1"><pathfill="currentColor"d="M19,21H8V7H19M19,5H8A2,2 0 0,0 6,7V21A2,2 0 0,0 8,23H19A2,2 0 0,0 21,21V7A2,2 0 0,0 19,5M16,1H4A2,2 0 0,0 2,3V17H4V3H16V1Z"></path></svg><svgviewBox="0 0 24 24"class="copyButtonSuccessIcon_IiZV"><pathfill="currentColor"d="M21,7L9,19L3.5,13.5L4.91,12.09L9,16.17L19.59,5.59L21,7Z"></path></svg></span></button></div></div></div>
<h2class="anchor anchorWithStickyNavbar_FNw8"id="writing-documentation">Writing documentation<aclass="hash-link"aria-label="Direct link to Writing documentation"title="Direct link to Writing documentation"href="/contributing#writing-documentation"></a></h2>
<h2class="anchor anchorWithStickyNavbar_FNw8"id="writing-tsdoc-comments">Writing TSDoc comments<aclass="hash-link"aria-label="Direct link to Writing TSDoc comments"title="Direct link to Writing TSDoc comments"href="/contributing#writing-tsdoc-comments"></a></h2>
<h2class="anchor anchorWithStickyNavbar_FNw8"id="running-the-documentation-site-locally">Running the documentation site locally<aclass="hash-link"aria-label="Direct link to Running the documentation site locally"title="Direct link to Running the documentation site locally"href="/contributing#running-the-documentation-site-locally"></a></h2>
<h2class="anchor anchorWithStickyNavbar_FNw8"id="adding-new-dependencies">Adding new dependencies<aclass="hash-link"aria-label="Direct link to Adding new dependencies"title="Direct link to Adding new dependencies"href="/contributing#adding-new-dependencies"></a></h2>
<h2class="anchor anchorWithStickyNavbar_FNw8"id="testing-tips">Testing tips<aclass="hash-link"aria-label="Direct link to Testing tips"title="Direct link to Testing tips"href="/contributing#testing-tips"></a></h2>
<h2class="anchor anchorWithStickyNavbar_FNw8"id="api-coverage">API Coverage<aclass="hash-link"aria-label="Direct link to API Coverage"title="Direct link to API Coverage"href="/contributing#api-coverage"></a></h2>
<h2class="anchor anchorWithStickyNavbar_FNw8"id="debugging-puppeteer">Debugging Puppeteer<aclass="hash-link"aria-label="Direct link to Debugging Puppeteer"title="Direct link to Debugging Puppeteer"href="/contributing#debugging-puppeteer"></a></h2>
<h3class="anchor anchorWithStickyNavbar_FNw8"id="debugging-puppeteer-tests-via-vscode">Debugging Puppeteer tests via VSCode<aclass="hash-link"aria-label="Direct link to Debugging Puppeteer tests via VSCode"title="Direct link to Debugging Puppeteer tests via VSCode"href="/contributing#debugging-puppeteer-tests-via-vscode"></a></h3>
<p>Copy the provided default <code>.vscode/launch.template.json</code> to <code>.vscode/launch.json</code> and then use the integrated VSCode debugger to debug test.</p>
<p>Remember to build test before launching via:</p>
<h2class="anchor anchorWithStickyNavbar_FNw8"id="rolling-new-chrome-version">Rolling new Chrome version<aclass="hash-link"aria-label="Direct link to Rolling new Chrome version"title="Direct link to Rolling new Chrome version"href="/contributing#rolling-new-chrome-version"></a></h2>
<p>There is a <ahref="https://github.com/puppeteer/puppeteer/blob/main/.github/workflows/update-browser-pins.yml"target="_blank"rel="noopener noreferrer">GitHub action</a> that runs once per day.
The action has a manual trigger that can be found on the <ahref="https://github.com/puppeteer/puppeteer/actions/workflows/update-browser-pins.yml"target="_blank"rel="noopener noreferrer">Actions Tab</a>.</p>
<h3class="anchor anchorWithStickyNavbar_FNw8"id="manual-instructions">Manual instructions<aclass="hash-link"aria-label="Direct link to Manual instructions"title="Direct link to Manual instructions"href="/contributing#manual-instructions"></a></h3>
<p>You can run the <ahref="https://github.com/puppeteer/puppeteer/blob/main/tools/update_chrome_revision.mjs"target="_blank"rel="noopener noreferrer"><code>tools/update_chrome_revision.mjs</code></a> locally
and try see if any changes need to be committed.</p>
<blockquote>
<p>Note: You may need to run <code>node --experimental-fetch tools/update_chrome_revision.mjs</code> as the script relies on <code>fetch</code></p>
</blockquote>
<p>The following steps are manual version of the script above.</p>
<ol>
<li>Find a suitable Chrome <code>revision</code> and <code>version</code> via <ahref="https://googlechromelabs.github.io/chrome-for-testing/"target="_blank"rel="noopener noreferrer">https://googlechromelabs.github.io/chrome-for-testing/</a> or <ahref="https://chromiumdash.appspot.com/"target="_blank"rel="noopener noreferrer">https://chromiumdash.appspot.com/</a>.</li>
<li>Update <code>packages/puppeteer-core/src/revisions.ts</code> with the found <code>version</code>
number.</li>
<li>Update <code>versions.js</code> with the new Chrome-to-Puppeteer <code>version</code> mapping and
<code>feat(chrome): roll to Chrome 90.0.4427.0 (r856583)</code>.</li>
</ol>
<blockquote>
<p>NOTE: Another place you can find version corresponding version is <ahref="https://omahaproxy.appspot.com/"target="_blank"rel="noopener noreferrer">omahaproxy.appspot.com</a> by
searching in <code>Find Releases</code> for <code>r<revision></code>.</p>
<h3class="anchor anchorWithStickyNavbar_FNw8"id="bisecting-upstream-changes">Bisecting upstream changes<aclass="hash-link"aria-label="Direct link to Bisecting upstream changes"title="Direct link to Bisecting upstream changes"href="/contributing#bisecting-upstream-changes"></a></h3>
<h2class="anchor anchorWithStickyNavbar_FNw8"id="releasing-to-npm">Releasing to npm<aclass="hash-link"aria-label="Direct link to Releasing to npm"title="Direct link to Releasing to npm"href="/contributing#releasing-to-npm"></a></h2>
<h3class="anchor anchorWithStickyNavbar_FNw8"id="in-case-release-please-fails">In case Release Please fails<aclass="hash-link"aria-label="Direct link to In case Release Please fails"title="Direct link to In case Release Please fails"href="/contributing#in-case-release-please-fails"></a></h3>
<h2class="anchor anchorWithStickyNavbar_FNw8"id="bug-triage-guidelines">Bug triage guidelines<aclass="hash-link"aria-label="Direct link to Bug triage guidelines"title="Direct link to Bug triage guidelines"href="/contributing#bug-triage-guidelines"></a></h2>
<p><ahref="https://github.com/puppeteer/puppeteer/issues"target="_blank"rel="noopener noreferrer">Check incoming bug reports</a> that do not have a <code>confirmed</code> or <code>needs-feedback</code> label:</p>
<ol>
<li>Make sure the issue is labeled as either <code>bug</code> or <code>feature</code>.</li>
<li>If the issue does not have a clear repro or you cannot repro, ask for the repro and set the <code>needs-feedback</code> label.</li>
<li>Follow-up on the issues you previously asked for a feedback on (you should get a notification on GitHub when the user responds).</li>
<li>If the user does not provide feedback, the issue will be closed by the stale bot eventually.</li>
<li>If you are able to reproduce the issue, add the label <code>confirmed</code>.</li>
<li>If the bug is on the Chromium side, create a corresponding crbug.com issue, label the GitHub issue with the <code>upstream</code> label, and post a link to crbug.com in the comments.</li>
<li>If the issue is not related to either Puppeteer or Chromium, close the issue.</li>
<li>If the issue is about missing/incorrect documentation, label it as <code>documentation</code>.</li>
</ol>
<p>Issues with PDFs:</p>
<ol>
<li>If the issue reproduces using the regular print dialog and/or headful, <ahref="https://bugs.chromium.org/p/chromium/issues/entry?components=Blink%3ELayout"target="_blank"rel="noopener noreferrer">file a crbug.com against the <code>Blink>Layout</code> component</a>.</li>
<li>If the issue is specific to Headless mode, <ahref="https://bugs.chromium.org/p/chromium/issues/entry?components=Internals%3EHeadless"target="_blank"rel="noopener noreferrer">file an issue on crbug.com against the <code>Internals>Headless</code> component</a>.</li>
