github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

docs: mention issues with buffer encoding (#12141)

Browse Source
This commit is contained in:
Alex Rudenko 2024-03-25 09:30:56 +01:00 committed by GitHub
parent 168856ec87
commit 00fa75ec9e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
docs/api/puppeteer.httpresponse.buffer.md
View File

@ -17,3 +17,7 @@ class HTTPResponse {
**Returns:** **Returns:**
Promise<Buffer> Promise<Buffer>
## Remarks
The buffer might be re-encoded by the browser based on HTTP-headers or other heuristics. If the browser failed to detect the correct encoding, the buffer might be encoded incorrectly. See https://github.com/puppeteer/puppeteer/issues/6478.

2
docs/api/puppeteer.httpresponse.md
View File

@ -171,7 +171,7 @@ The status text of the response (e.g. usually an "OK" for a success).
</td><td> </td><td>
Promise which resolves to a text representation of response body. Promise which resolves to a text (utf8) representation of response body.
</td></tr> </td></tr>
<tr><td> <tr><td>

2
docs/api/puppeteer.httpresponse.text.md
View File

@ -4,7 +4,7 @@ sidebar_label: HTTPResponse.text
# HTTPResponse.text() method # HTTPResponse.text() method
Promise which resolves to a text representation of response body. Promise which resolves to a text (utf8) representation of response body.
#### Signature: #### Signature:

9
packages/puppeteer-core/src/api/HTTPResponse.ts
View File

@ -81,11 +81,18 @@ export abstract class HTTPResponse {
/** /**
* Promise which resolves to a buffer with response body. * Promise which resolves to a buffer with response body.
*
* @remarks
*
* The buffer might be re-encoded by the browser
* based on HTTP-headers or other heuristics. If the browser
* failed to detect the correct encoding, the buffer might
* be encoded incorrectly. See https://github.com/puppeteer/puppeteer/issues/6478.
*/ */
abstract buffer(): Promise<Buffer>; abstract buffer(): Promise<Buffer>;
/** /**
* Promise which resolves to a text representation of response body. * Promise which resolves to a text (utf8) representation of response body.
*/ */
async text(): Promise<string> { async text(): Promise<string> {
const content = await this.buffer(); const content = await this.buffer();