github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: update tests for aborted requests (#10476)

Browse Source
This commit is contained in:
Alex Rudenko 2023-06-30 11:56:16 +02:00 committed by GitHub
parent 74f588f1c1
commit 02634d80da
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
test/TestExpectations.json
View File

@ -953,6 +953,12 @@
"parameters": ["webDriverBiDi"], "parameters": ["webDriverBiDi"],
"expectations": ["FAIL"] "expectations": ["FAIL"]
}, },
{
"testIdPattern": "[navigation.spec] navigation Frame.goto should reject when frame detaches",
"platforms": ["darwin", "linux", "win32"],
"parameters": ["webDriverBiDi"],
"expectations": ["PASS"]
},
{ {
"testIdPattern": "[navigation.spec] navigation Page.goto should fail when navigating to bad SSL", "testIdPattern": "[navigation.spec] navigation Page.goto should fail when navigating to bad SSL",
"platforms": ["darwin", "linux", "win32"], "platforms": ["darwin", "linux", "win32"],
@ -2453,12 +2459,6 @@
"parameters": ["chrome", "webDriverBiDi"], "parameters": ["chrome", "webDriverBiDi"],
"expectations": ["PASS"] "expectations": ["PASS"]
}, },
{
"testIdPattern": "[navigation.spec] navigation Frame.goto should reject when frame detaches",
"platforms": ["darwin", "linux", "win32"],
"parameters": ["cdp", "chrome"],
"expectations": ["FAIL", "PASS"]
},
{ {
"testIdPattern": "[navigation.spec] navigation Frame.goto should reject when frame detaches", "testIdPattern": "[navigation.spec] navigation Frame.goto should reject when frame detaches",
"platforms": ["darwin", "linux", "win32"], "platforms": ["darwin", "linux", "win32"],

6
test/src/navigation.spec.ts
View File

@ -803,7 +803,11 @@ describe('navigation', function () {
return frame.remove(); return frame.remove();
}); });
const error = await navigationPromise; const error = await navigationPromise;
expect(error.message).toBe('Navigating frame was detached'); expect(error.message).atLeastOneToContain([
'Navigating frame was detached',
'Error: NS_BINDING_ABORTED',
'net::ERR_ABORTED',
]);
}); });
it('should return matching responses', async () => { it('should return matching responses', async () => {
const {page, server} = await getTestState(); const {page, server} = await getTestState();