From 02720e4f22450a2120d595436c74d79f10cea30c Mon Sep 17 00:00:00 2001
From: Andrey Lushnikov <aslushnikov@gmail.com>
Date: Wed, 27 Dec 2017 19:38:33 -0700
Subject: [PATCH] test: do not leave dangling listener on shared browser object
 (#1674)

This resulted in quite a few failures on travis.
---
 test/test.js | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/test/test.js b/test/test.js
index e91530c4e77..de77d1b95fa 100644
--- a/test/test.js
+++ b/test/test.js
@@ -3348,9 +3348,9 @@ describe('Page', function() {
       expect((await changedTarget).url()).toBe(server.EMPTY_PAGE);
     });
     it('should not report uninitialized pages', async({page, server, browser}) => {
-      browser.on('targetchanged', () => {
-        expect(false).toBe(true, 'target should not be reported as changed');
-      });
+      let targetChanged = false;
+      const listener = () => targetChanged = true;
+      browser.on('targetchanged', listener);
       const targetPromise = new Promise(fulfill => browser.once('targetcreated', target => fulfill(target)));
       const newPagePromise = browser.newPage();
       const target = await targetPromise;
@@ -3363,6 +3363,8 @@ describe('Page', function() {
       expect(target2.url()).toBe('about:blank');
       await evaluatePromise;
       await newPage.close();
+      expect(targetChanged).toBe(false, 'target should not be reported as changed');
+      browser.removeListener('targetchanged', listener);
     });
     it('should not crash while redirecting if original request was missed', async({page, server, browser}) => {
       let serverResponse = null;