github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: update tests (#12081)

Browse Source
This commit is contained in:
Nikolay Vitkov 2024-03-13 16:55:34 +01:00 committed by GitHub
parent 26376224d5
commit 02b9678f85
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 25 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
test/TestExpectations.json
View File

@ -467,6 +467,13 @@
"expectations": ["FAIL"], "expectations": ["FAIL"],
"comment": "TODO: add a comment explaining why this expectation is required (include links to issues)" "comment": "TODO: add a comment explaining why this expectation is required (include links to issues)"
}, },
{
"testIdPattern": "[jshandle.spec] JSHandle JSHandle.toString should work with window subtypes",
"platforms": ["darwin", "linux", "win32"],
"parameters": ["cdp"],
"expectations": ["FAIL"],
"comment": "CDP does not have special type for window"
},
{ {
"testIdPattern": "[jshandle.spec] JSHandle Page.evaluateHandle should return the RemoteObject", "testIdPattern": "[jshandle.spec] JSHandle Page.evaluateHandle should return the RemoteObject",
"platforms": ["darwin", "linux", "win32"], "platforms": ["darwin", "linux", "win32"],
@ -685,7 +692,7 @@
"platforms": ["darwin", "linux", "win32"], "platforms": ["darwin", "linux", "win32"],
"parameters": ["webDriverBiDi"], "parameters": ["webDriverBiDi"],
"expectations": ["FAIL"], "expectations": ["FAIL"],
"comment": "TODO: add a comment explaining why this expectation is required (include links to issues)" "comment": "BiDi does not support getting a Handle for log args"
}, },
{ {
"testIdPattern": "[page.spec] Page Page.Events.Console should return remote objects", "testIdPattern": "[page.spec] Page Page.Events.Console should return remote objects",

10
test/src/jshandle.spec.ts
View File

@ -326,6 +326,16 @@ describe('JSHandle', function () {
'JSHandle@proxy' 'JSHandle@proxy'
); );
}); });
it('should work with window subtypes', async () => {
const {page} = await getTestState();
expect((await page.evaluateHandle('window')).toString()).toBe(
'JSHandle@window'
);
expect((await page.evaluateHandle('globalThis')).toString()).toBe(
'JSHandle@window'
);
});
}); });
describe('JSHandle[Symbol.dispose]', () => { describe('JSHandle[Symbol.dispose]', () => {

11
test/src/page.spec.ts
View File

@ -506,11 +506,14 @@ describe('Page', function () {
console.log(1, 2, 3, globalThis); console.log(1, 2, 3, globalThis);
}); });
const log = await logPromise; const log = await logPromise;
expect(log.text()).toBe('1 2 3 JSHandle@object');
expect(log.text()).atLeastOneToContain([
'1 2 3 JSHandle@object',
'1 2 3 JSHandle@window',
]);
expect(log.args()).toHaveLength(4); expect(log.args()).toHaveLength(4);
expect(await (await log.args()[3]!.getProperty('test')).jsonValue()).toBe( using property = await log.args()[3]!.getProperty('test');
1 expect(await property.jsonValue()).toBe(1);
);
}); });
it('should trigger correct Log', async () => { it('should trigger correct Log', async () => {
const {page, server, isChrome} = await getTestState(); const {page, server, isChrome} = await getTestState();