github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

ci: add lint for expectations (#11365)

Browse Source
This commit is contained in:
Alex Rudenko 2023-11-13 13:39:24 +01:00 committed by GitHub
parent 915eb7ff4e
commit 02d62be58e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 21 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
package.json
View File

@ -20,6 +20,7 @@
"lint": "run-s lint:*", "lint": "run-s lint:*",
"lint:eslint": "([ \"$CI\" = true ] && eslint --ext js --ext ts --quiet . || eslint --ext js --ext ts .)", "lint:eslint": "([ \"$CI\" = true ] && eslint --ext js --ext ts --quiet . || eslint --ext js --ext ts .)",
"lint:prettier": "prettier --check .", "lint:prettier": "prettier --check .",
"lint:expectations": "node tools/sort-test-expectations.js --lint",
"postinstall": "npm run postinstall --workspaces --if-present", "postinstall": "npm run postinstall --workspaces --if-present",
"prepare": "npm run prepare --workspaces --if-present", "prepare": "npm run prepare --workspaces --if-present",
"test": "wireit", "test": "wireit",

13
tools/sort-test-expectations.js
View File

@ -25,6 +25,8 @@ const source = 'test/TestExpectations.json';
const testExpectations = JSON.parse(fs.readFileSync(source, 'utf-8')); const testExpectations = JSON.parse(fs.readFileSync(source, 'utf-8'));
const commitedExpectations = structuredClone(testExpectations);
function getSpecificity(item) { function getSpecificity(item) {
return ( return (
item.parameters.length + item.parameters.length +
@ -50,6 +52,16 @@ testExpectations.forEach(item => {
item.platforms.sort(); item.platforms.sort();
}); });
if (process.argv.includes('--lint')) {
if (
JSON.stringify(commitedExpectations) !== JSON.stringify(testExpectations)
) {
console.error(
`${source} is not formatted properly. Run 'npm run format:expectations'.`
);
process.exit(1);
}
} else {
fs.writeFileSync( fs.writeFileSync(
source, source,
prettier.format(JSON.stringify(testExpectations), { prettier.format(JSON.stringify(testExpectations), {
@ -57,3 +69,4 @@ fs.writeFileSync(
parser: 'json', parser: 'json',
}) })
); );
}