github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: ignore favicon requests in page.spec event handler tests (#8208)

Browse Source
This commit is contained in:
Julian Descottes 2022-04-07 18:06:12 +02:00 committed by GitHub
parent 0955225b51
commit 04e5c88997
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 19 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
test/page.spec.ts
View File

@ -127,14 +127,20 @@ describe('Page', function () {
const { page, server } = getTestState(); const { page, server } = getTestState();
const handler = sinon.spy(); const handler = sinon.spy();
page.on('response', handler); const onResponse = (response) => {
// Ignore default favicon requests.
if (!response.url().endsWith('favicon.ico')) {
handler();
}
};
page.on('response', onResponse);
await page.goto(server.EMPTY_PAGE); await page.goto(server.EMPTY_PAGE);
expect(handler.callCount).toBe(1); expect(handler.callCount).toBe(1);
page.off('response', handler); page.off('response', onResponse);
await page.goto(server.EMPTY_PAGE); await page.goto(server.EMPTY_PAGE);
// Still one because we removed the handler. // Still one because we removed the handler.
expect(handler.callCount).toBe(1); expect(handler.callCount).toBe(1);
page.on('response', handler); page.on('response', onResponse);
await page.goto(server.EMPTY_PAGE); await page.goto(server.EMPTY_PAGE);
// Two now because we added the handler back. // Two now because we added the handler back.
expect(handler.callCount).toBe(2); expect(handler.callCount).toBe(2);
@ -144,14 +150,21 @@ describe('Page', function () {
const { page, server } = getTestState(); const { page, server } = getTestState();
const handler = sinon.spy(); const handler = sinon.spy();
page.on('request', handler); const onResponse = (response) => {
// Ignore default favicon requests.
if (!response.url().endsWith('favicon.ico')) {
handler();
}
};
page.on('request', onResponse);
await page.goto(server.EMPTY_PAGE); await page.goto(server.EMPTY_PAGE);
expect(handler.callCount).toBe(1); expect(handler.callCount).toBe(1);
page.off('request', handler); page.off('request', onResponse);
await page.goto(server.EMPTY_PAGE); await page.goto(server.EMPTY_PAGE);
// Still one because we removed the handler. // Still one because we removed the handler.
expect(handler.callCount).toBe(1); expect(handler.callCount).toBe(1);
page.on('request', handler); page.on('request', onResponse);
await page.goto(server.EMPTY_PAGE); await page.goto(server.EMPTY_PAGE);
// Two now because we added the handler back. // Two now because we added the handler back.
expect(handler.callCount).toBe(2); expect(handler.callCount).toBe(2);