github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(NetworkManager): Remove header 'cookie' from request hash (#2954)

Browse Source 
This fixes an issue in which a response may not be recorded or trigger an event because of differing cookie headers from the request.

References #2970
This commit is contained in:
Donovan Allen 2018-07-30 18:06:53 -06:00 committed by Andrey Lushnikov
parent 392d3b94bd
commit 0b12119843
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/NetworkManager.js
View File

@ -675,7 +675,7 @@ function generateRequestHash(request) {
for (let header of headers) { for (let header of headers) {
const headerValue = request.headers[header]; const headerValue = request.headers[header];
header = header.toLowerCase(); header = header.toLowerCase();
if (header === 'accept' || header === 'referer' || header === 'x-devtools-emulate-network-conditions-client-id') if (header === 'accept' || header === 'referer' || header === 'x-devtools-emulate-network-conditions-client-id' || header === 'cookie')
continue; continue;
hash.headers[header] = headerValue; hash.headers[header] = headerValue;
} }