From 1998104489dec5752da08c98fc8017409b3ecf1c Mon Sep 17 00:00:00 2001 From: JoelEinbinder Date: Fri, 28 Jul 2017 11:08:13 -0700 Subject: [PATCH] run phantom tests on windows (#163) Allow running phantom tests on Windows. These were relying on #!/usr/bin/env node at the top of runner.js, which doesn't work outside of a unix environment. --- third_party/phantomjs/test/run-tests.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/third_party/phantomjs/test/run-tests.py b/third_party/phantomjs/test/run-tests.py index e535c51f795..038dda6d2cc 100755 --- a/third_party/phantomjs/test/run-tests.py +++ b/third_party/phantomjs/test/run-tests.py @@ -768,13 +768,13 @@ class TestRunner(object): def get_base_command(self, debugger): if debugger is None: - return [self.phantomjs_exe] + return ["node", self.phantomjs_exe] elif debugger == "gdb": - return ["gdb", "--args", self.phantomjs_exe] + return ["gdb", "--args", "node", self.phantomjs_exe] elif debugger == "lldb": - return ["lldb", "--", self.phantomjs_exe] + return ["lldb", "--", "node", self.phantomjs_exe] elif debugger == "valgrind": - return ["valgrind", self.phantomjs_exe] + return ["valgrind", "node", self.phantomjs_exe] else: raise RuntimeError("Don't know how to invoke " + self.debugger)