github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: remove skip and add more frame.name() instructions (#12085)

Browse Source
This commit is contained in:
jrandolf 2024-03-13 15:44:42 +01:00 committed by GitHub
parent 0203b4533d
commit 1a05d37cf2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/api/puppeteer.frame.name.md
View File

@ -10,7 +10,7 @@ sidebar_label: Frame.name
> >
> ```ts > ```ts
> const element = await frame.frameElement(); > const element = await frame.frameElement();
> const name = await element.evaluate(frame => frame.name); > const nameOrId = await element.evaluate(frame => frame.name ?? frame.id);
> ``` > ```
The frame's `name` attribute as specified in the tag. The frame's `name` attribute as specified in the tag.

2
packages/puppeteer-core/src/api/Frame.ts
View File

@ -765,7 +765,7 @@ export abstract class Frame extends EventEmitter<FrameEvents> {
* *
* ```ts * ```ts
* const element = await frame.frameElement(); * const element = await frame.frameElement();
* const name = await element.evaluate(frame => frame.name); * const nameOrId = await element.evaluate(frame => frame.name ?? frame.id);
* ``` * ```
*/ */
name(): string { name(): string {

2
test/src/launcher.spec.ts
View File

@ -777,7 +777,7 @@ describe('Launcher specs', function () {
await close(); await close();
} }
}); });
it.skip('should be able to reconnect to a disconnected browser', async () => { it('should be able to reconnect to a disconnected browser', async () => {
const {puppeteer, server, browser, close} = await launch({}); const {puppeteer, server, browser, close} = await launch({});
try { try {
const browserWSEndpoint = browser.wsEndpoint(); const browserWSEndpoint = browser.wsEndpoint();