github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: only lookup localhost for DNS lookups

Browse Source
This commit is contained in:
Randolf J 2022-06-04 01:04:11 +02:00
parent eb7cd717ed
commit 1b025b4c84
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/node/NodeWebSocketTransport.ts
View File

@ -23,13 +23,15 @@ export class NodeWebSocketTransport implements ConnectionTransport {
// TODO(jrandolf): Starting in Node 17, IPv6 is favoured over IPv4 due to a change // TODO(jrandolf): Starting in Node 17, IPv6 is favoured over IPv4 due to a change
// in a default option: // in a default option:
// - https://github.com/nodejs/node/issues/40537, // - https://github.com/nodejs/node/issues/40537,
// Due to this, we parse and resolve the hostname manually with the previous // Due to this, for Firefox, we must parse and resolve the `localhost` hostname
// behavior according to: // manually with the previous behavior according to:
// - https://nodejs.org/api/dns.html#dnslookuphostname-options-callback // - https://nodejs.org/api/dns.html#dnslookuphostname-options-callback
// because of https://bugzilla.mozilla.org/show_bug.cgi?id=1769994. // because of https://bugzilla.mozilla.org/show_bug.cgi?id=1769994.
const url = new URL(urlString); const url = new URL(urlString);
if (url.hostname === 'localhost') {
const { address } = await dns.lookup(url.hostname, { verbatim: false }); const { address } = await dns.lookup(url.hostname, { verbatim: false });
url.hostname = address; url.hostname = address;
}
return new Promise((resolve, reject) => { return new Promise((resolve, reject) => {
const ws = new NodeWebSocket(url, [], { const ws = new NodeWebSocket(url, [], {