From 26d800cae811450dc7af3d3facfe7bf927c0d9fd Mon Sep 17 00:00:00 2001 From: Alex Rudenko Date: Mon, 3 Jun 2024 15:27:18 +0200 Subject: [PATCH] test: fix the window.stop test (#12526) --- test/TestExpectations.json | 9 +-------- test/src/navigation.spec.ts | 3 --- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/test/TestExpectations.json b/test/TestExpectations.json index 19eb767b81c..e2c047942f7 100644 --- a/test/TestExpectations.json +++ b/test/TestExpectations.json @@ -2379,19 +2379,12 @@ "expectations": ["SKIP"], "comment": "TODO: add a comment explaining why this expectation is required (include links to issues)" }, - { - "testIdPattern": "[navigation.spec] navigation Page.waitForNavigation should work when subframe issues window.stop()", - "platforms": ["darwin", "linux", "win32"], - "parameters": ["firefox", "webDriverBiDi"], - "expectations": ["SKIP"], - "comment": "TODO: add a comment explaining why this expectation is required (include links to issues)" - }, { "testIdPattern": "[navigation.spec] navigation Page.waitForNavigation should work when subframe issues window.stop()", "platforms": ["darwin", "linux", "win32"], "parameters": ["chrome", "webDriverBiDi"], "expectations": ["SKIP"], - "comment": "TODO: add a comment explaining why this expectation is required (include links to issues)" + "comment": "TODO: evaluating in the frame that was just attached causes an error in chromium-bidi" }, { "testIdPattern": "[navigation.spec] navigation Page.waitForNavigation should work with DOM history.back()/history.forward()", diff --git a/test/src/navigation.spec.ts b/test/src/navigation.spec.ts index 927dd02cd58..3d2b1dda6d5 100644 --- a/test/src/navigation.spec.ts +++ b/test/src/navigation.spec.ts @@ -719,9 +719,6 @@ describe('navigation', function () { waitEvent(page, 'frameattached').then(_frame => { return (frame = _frame); }), - waitEvent(page, 'framenavigated', f => { - return f === frame; - }), ]), Deferred.create({ message: `should work when subframe issues window.stop()`,