github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: require comments on expectations (#12038)

Browse Source
This commit is contained in:
Alex Rudenko 2024-03-04 16:23:12 +01:00 committed by GitHub
parent 7fe22b533d
commit 2ef161be3c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 1056 additions and 519 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1557
test/TestExpectations.json
View File

File diff suppressed because it is too large Load Diff

18
tools/sort-test-expectations.mjs
View File

@ -120,6 +120,16 @@ testExpectations = testExpectations.filter(item => {
}); });
if (process.argv.includes('--lint')) { if (process.argv.includes('--lint')) {
const missingComments = [];
testExpectations.forEach(item => {
if (item.expectations.length === 1 && item.expectations[0] === 'PASS') {
return;
}
if (!item.comment) {
missingComments.push(item);
}
});
if ( if (
JSON.stringify(committedExpectations) !== JSON.stringify(testExpectations) JSON.stringify(committedExpectations) !== JSON.stringify(testExpectations)
) { ) {
@ -128,6 +138,14 @@ if (process.argv.includes('--lint')) {
); );
process.exit(1); process.exit(1);
} }
if (missingComments.length > 0) {
console.error(
`${source}: missing comments for the following expectations:`,
missingComments
);
process.exit(1);
}
} else { } else {
fs.writeFileSync( fs.writeFileSync(
source, source,