github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: don't run destroyHandles if realm is already disposed (#12365)

Browse Source
This commit is contained in:
Nikolay Vitkov 2024-04-30 07:59:07 +02:00 committed by GitHub
parent 41d43200b7
commit 3103744a67
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/puppeteer-core/src/api/Realm.ts
View File

@ -95,10 +95,14 @@ export abstract class Realm implements Disposable {
#disposed = false; #disposed = false;
/** @internal */ /** @internal */
[disposeSymbol](): void { dispose(): void {
this.#disposed = true; this.#disposed = true;
this.taskManager.terminateAll( this.taskManager.terminateAll(
new Error('waitForFunction failed: frame got detached.') new Error('waitForFunction failed: frame got detached.')
); );
} }
/** @internal */
[disposeSymbol](): void {
this.dispose();
}
} }

5
packages/puppeteer-core/src/bidi/Realm.ts
View File

@ -53,6 +53,7 @@ export abstract class BidiRealm extends Realm {
protected initialize(): void { protected initialize(): void {
this.realm.on('destroyed', ({reason}) => { this.realm.on('destroyed', ({reason}) => {
this.taskManager.terminateAll(new Error(reason)); this.taskManager.terminateAll(new Error(reason));
this.dispose();
}); });
this.realm.on('updated', () => { this.realm.on('updated', () => {
this.internalPuppeteerUtil = undefined; this.internalPuppeteerUtil = undefined;
@ -224,6 +225,10 @@ export abstract class BidiRealm extends Realm {
} }
async destroyHandles(handles: Array<BidiJSHandle<unknown>>): Promise<void> { async destroyHandles(handles: Array<BidiJSHandle<unknown>>): Promise<void> {
if (this.disposed) {
return;
}
const handleIds = handles const handleIds = handles
.map(({id}) => { .map(({id}) => {
return id; return id;