github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: use WeakMap and null for DepthCalculator (#9892)

Browse Source
This commit is contained in:
jrandolf 2023-03-21 14:09:50 +01:00 committed by GitHub
parent 1f76cdda12
commit 323db305f0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/puppeteer-core/src/injected/PQuerySelector.ts
View File

@ -172,10 +172,10 @@ class PQueryEngine {
} }
class DepthCalculator { class DepthCalculator {
#cache = new Map<Node, number[]>(); #cache = new WeakMap<Node, number[]>();
calculate(node: Node, depth: number[] = []): number[] { calculate(node: Node | null, depth: number[] = []): number[] {
if (node instanceof Document) { if (node === null) {
return depth; return depth;
} }
if (node instanceof ShadowRoot) { if (node instanceof ShadowRoot) {
@ -196,7 +196,7 @@ class DepthCalculator {
++index; ++index;
} }
const value = this.calculate(node.parentNode as Node, [index]); const value = this.calculate(node.parentNode, [index]);
this.#cache.set(node, value); this.#cache.set(node, value);
return [...value, ...depth]; return [...value, ...depth];
} }