From 32c0363adefa39a418d0cab1f2d2a818d391f017 Mon Sep 17 00:00:00 2001
From: Andrey Lushnikov <aslushnikov@gmail.com>
Date: Tue, 4 Sep 2018 10:04:27 +0100
Subject: [PATCH] feat(chromium): roll Chromium to r588429 (#3181)

This roll includes:
- https://crrev.com/588420 - DevTools: teach request interception to work with
  Security.setIgnoreCertificateErrors

Fixes #1159.
---
 package.json                   | 2 +-
 test/ignorehttpserrors.spec.js | 6 ++++++
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/package.json b/package.json
index 4860c7d8e47..e9c9601ebba 100644
--- a/package.json
+++ b/package.json
@@ -8,7 +8,7 @@
     "node": ">=6.4.0"
   },
   "puppeteer": {
-    "chromium_revision": "587164"
+    "chromium_revision": "588429"
   },
   "scripts": {
     "unit": "node test/test.js",
diff --git a/test/ignorehttpserrors.spec.js b/test/ignorehttpserrors.spec.js
index 17d21d37d7e..9730b5f280d 100644
--- a/test/ignorehttpserrors.spec.js
+++ b/test/ignorehttpserrors.spec.js
@@ -55,6 +55,12 @@ module.exports.addTests = function({testRunner, expect, defaultBrowserOptions})
       const securityDetails = responses[0].securityDetails();
       expect(securityDetails.protocol()).toBe('TLS 1.2');
     });
+    it('should work with request interception', async({page, server, httpsServer}) => {
+      await page.setRequestInterception(true);
+      page.on('request', request => request.continue());
+      const response = await page.goto(httpsServer.EMPTY_PAGE);
+      expect(response.status()).toBe(200);
+    });
     it('should work with mixed content', async({page, server, httpsServer}) => {
       httpsServer.setRoute('/mixedcontent.html', (req, res) => {
         res.end(`<iframe src=${server.EMPTY_PAGE}></iframe>`);