github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: fix a failing screenshot test for BiDi (#11675)

Browse Source
This commit is contained in:
Alex Rudenko 2024-01-15 07:03:47 +01:00 committed by GitHub
parent a87a035879
commit 3465e3012b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test/TestExpectations.json
View File

@ -3368,12 +3368,6 @@
"parameters": ["cdp", "firefox"], "parameters": ["cdp", "firefox"],
"expectations": ["FAIL", "PASS"] "expectations": ["FAIL", "PASS"]
}, },
{
"testIdPattern": "[screenshot.spec] Screenshots Page.screenshot should work with odd clip size on Retina displays",
"platforms": ["darwin", "linux", "win32"],
"parameters": ["firefox", "webDriverBiDi"],
"expectations": ["FAIL"]
},
{ {
"testIdPattern": "[stacktrace.spec] Stack trace should work for none error objects", "testIdPattern": "[stacktrace.spec] Stack trace should work for none error objects",
"platforms": ["darwin", "linux", "win32"], "platforms": ["darwin", "linux", "win32"],

3
test/src/screenshot.spec.ts
View File

@ -148,6 +148,9 @@ describe('Screenshots', function () {
it('should work with odd clip size on Retina displays', async () => { it('should work with odd clip size on Retina displays', async () => {
const {page} = await getTestState(); const {page} = await getTestState();
// Make sure documentElement height is at least 11px.
await page.setContent(`<div style="width: 11px; height: 11px;">`);
const screenshot = await page.screenshot({ const screenshot = await page.screenshot({
clip: { clip: {
x: 0, x: 0,