refactor: move target updates to the target manager (#10189)

packages/puppeteer-core/src/common/Browser.ts

@@ -374,22 +374,11 @@ export class CDPBrowser extends BrowserBase {
     }
   };
 
-  #onTargetChanged = ({
+  #onTargetChanged = ({target}: {target: Target}): void => {
-    target,
-    targetInfo,
-  }: {
-    target: Target;
-    targetInfo: Protocol.Target.TargetInfo;
-  }): void => {
-    const previousURL = target.url();
-    const wasInitialized = target._isInitialized;
-    target._targetInfoChanged(targetInfo);
-    if (wasInitialized && previousURL !== target.url()) {
     this.emit(BrowserEmittedEvents.TargetChanged, target);
     target
       .browserContext()
       .emit(BrowserContextEmittedEvents.TargetChanged, target);
-    }
   };
 
   #onTargetDiscovered = (targetInfo: Protocol.Target.TargetInfo): void => {

packages/puppeteer-core/src/common/ChromeTargetManager.ts

@@ -263,10 +263,21 @@ export class ChromeTargetManager extends EventEmitter implements TargetManager {
     const target = this.#attachedTargetsByTargetId.get(
       event.targetInfo.targetId
     );
+    if (!target) {
+      return;
+    }
+    const previousURL = target.url();
+    const wasInitialized = target._isInitialized;
+
+    target._targetInfoChanged(event.targetInfo);
+
+    if (wasInitialized && previousURL !== target.url()) {
       this.emit(TargetManagerEmittedEvents.TargetChanged, {
-      target: target!,
+        target: target,
-      targetInfo: event.targetInfo,
+        wasInitialized,
+        previousURL,
       });
+    }
   };
 
   #onAttachedToTarget = async (

packages/puppeteer-core/src/common/TargetManager.ts

@@ -68,5 +68,8 @@ export const enum TargetManagerEmittedEvents {
   TargetDiscovered = 'targetDiscovered',
   TargetAvailable = 'targetAvailable',
   TargetGone = 'targetGone',
+  /**
+   * Emitted after a target has been initialized and whenever its URL changes.
+   */
   TargetChanged = 'targetChanged',
 }