github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: avoid unnecessary zero-delays in input code (#4934)

Browse Source
This commit is contained in:
Yury Semikhatsky 2019-10-20 23:29:56 -07:00 committed by Mathias Bynens
parent 11ff374ca3
commit 3773229ac2
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
lib/Input.js
View File

@ -156,16 +156,15 @@ class Keyboard {
* @param {{delay: (number|undefined)}=} options
*/
async type(text, options) {
let delay = 0;
if (options && options.delay)
delay = options.delay;
const delay = (options && options.delay) || null;
for (const char of text) {
if (keyDefinitions[char])
if (keyDefinitions[char]) {
await this.press(char, {delay});
else
} else {
if (delay)
await new Promise(f => setTimeout(f, delay));
await this.sendCharacter(char);
if (delay)
await new Promise(f => setTimeout(f, delay));
}
}
}
@ -176,7 +175,7 @@ class Keyboard {
async press(key, options = {}) {
const {delay = null} = options;
await this.down(key, options);
if (delay !== null)
if (delay)
await new Promise(f => setTimeout(f, options.delay));
await this.up(key);
}