github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

ci: use .nvmrc everywhere (#11747)

Browse Source
This commit is contained in:
Nikolay Vitkov 2024-01-25 10:20:58 +01:00 committed by GitHub
parent b53de4e094
commit 3a4a23faa8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
.github/workflows/ci.yml vendored
View File

@ -328,6 +328,8 @@ jobs:
name: Build installation test name: Build installation test
runs-on: ubuntu-latest runs-on: ubuntu-latest
needs: check-changes needs: check-changes
outputs:
node-version: ${{ steps.node-version.outputs.node }}
if: ${{ !startsWith(github.ref_name, 'release-please') && contains(fromJSON(needs.check-changes.outputs.changes), 'puppeteer') }} if: ${{ !startsWith(github.ref_name, 'release-please') && contains(fromJSON(needs.check-changes.outputs.changes), 'puppeteer') }}
steps: steps:
- name: Checkout - name: Checkout
@ -337,6 +339,9 @@ jobs:
with: with:
cache: npm cache: npm
node-version-file: '.nvmrc' node-version-file: '.nvmrc'
- name: Config Node.JS for installation test run
id: node-version
run: echo "node=$(cat .nvmrc)" >> "$GITHUB_OUTPUT"
- name: Install dependencies - name: Install dependencies
run: npm ci run: npm ci
env: env:
@ -361,8 +366,6 @@ jobs:
matrix: matrix:
linux-only: linux-only:
- ${{ github.event_name == 'pull_request' && !contains(github.head_ref, 'release-please') && !contains(github.event.pull_request.labels.*.name, 'full-ci') }} - ${{ github.event_name == 'pull_request' && !contains(github.head_ref, 'release-please') && !contains(github.event.pull_request.labels.*.name, 'full-ci') }}
node:
- 18
pkg_manager: pkg_manager:
- npm - npm
os: os:
@ -384,7 +387,7 @@ jobs:
- name: Set up Node.js - name: Set up Node.js
uses: actions/setup-node@b39b52d1213e96004bfcb1c61a8a6fa8ab84f3e8 # v4.0.1 uses: actions/setup-node@b39b52d1213e96004bfcb1c61a8a6fa8ab84f3e8 # v4.0.1
with: with:
node-version: ${{ matrix.node }} node-version-file: ${{ needs.installation-test-build.node-version }}
- name: Install dependencies - name: Install dependencies
run: ${{ matrix.pkg_manager }} install run: ${{ matrix.pkg_manager }} install
- name: Test - name: Test