github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(coverage): report anonymous scripts with debugger:// urls (#2875)

Browse Source 
Chrome DevTools shows anonymous scripts with yellow background and names
them with `debugger://VM<scriptId>` prefix.

This patch starts reporting the same debugger:// urls for anonymous
scripts in puppeteer's JS coverage. This might simplify debugging, e.g.
using `debugger;` statement to reveal the script in DevTools and later
matching it against the one in the coverage.
This commit is contained in:
Andrey Lushnikov 2018-07-11 21:05:16 -07:00 committed by GitHub
parent 254bc80811
commit 3ebbf125ff
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 23 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/Coverage.js
View File

@ -144,7 +144,9 @@ class JSCoverage {
const coverage = []; const coverage = [];
for (const entry of profileResponse.result) { for (const entry of profileResponse.result) {
const url = this._scriptURLs.get(entry.scriptId); let url = this._scriptURLs.get(entry.scriptId);
if (!url && this._reportAnonymousScripts)
url = 'debugger://VM' + entry.scriptId;
const text = this._scriptSources.get(entry.scriptId); const text = this._scriptSources.get(entry.scriptId);
if (text === undefined || url === undefined) if (text === undefined || url === undefined)
continue; continue;

41
test/coverage.spec.js
View File

@ -38,27 +38,26 @@ module.exports.addTests = function({testRunner, expect}) {
expect(coverage.length).toBe(1); expect(coverage.length).toBe(1);
expect(coverage[0].url).toBe('nicename.js'); expect(coverage[0].url).toBe('nicename.js');
}); });
describe('anonymous scripts coverage', function() { it('should ignore eval() scripts by default', async function({page, server}) {
it('should ignore eval() scripts by default', async function({page, server}) { await page.coverage.startJSCoverage();
await page.coverage.startJSCoverage(); await page.goto(server.PREFIX + '/jscoverage/eval.html');
await page.goto(server.PREFIX + '/jscoverage/eval.html'); const coverage = await page.coverage.stopJSCoverage();
const coverage = await page.coverage.stopJSCoverage(); expect(coverage.length).toBe(1);
expect(coverage.length).toBe(1); });
}); it('shouldn\'t ignore eval() scripts if reportAnonymousScripts is true', async function({page, server}) {
it('shouldn\'t ignore eval() scripts if reportAnonymousScripts is true', async function({page, server}) { await page.coverage.startJSCoverage({reportAnonymousScripts: true});
await page.coverage.startJSCoverage({reportAnonymousScripts: true}); await page.goto(server.PREFIX + '/jscoverage/eval.html');
await page.goto(server.PREFIX + '/jscoverage/eval.html'); const coverage = await page.coverage.stopJSCoverage();
const coverage = await page.coverage.stopJSCoverage(); expect(coverage.find(entry => entry.url.startsWith('debugger://'))).not.toBe(null);
expect(coverage.length).toBe(2); expect(coverage.length).toBe(2);
}); });
it('should ignore injected scripts regardless of reportAnonymousScripts', async function({page, server}) { it('should ignore pptr internal scripts if reportAnonymousScripts is true', async function({page, server}) {
await page.coverage.startJSCoverage({reportAnonymousScripts: true}); await page.coverage.startJSCoverage({reportAnonymousScripts: true});
await page.goto(server.EMPTY_PAGE); await page.goto(server.EMPTY_PAGE);
await page.evaluate('console.log("foo")'); await page.evaluate('console.log("foo")');
await page.evaluate(() => console.log('bar')); await page.evaluate(() => console.log('bar'));
const coverage = await page.coverage.stopJSCoverage(); const coverage = await page.coverage.stopJSCoverage();
expect(coverage.length).toBe(0); expect(coverage.length).toBe(0);
});
}); });
it('should report multiple scripts', async function({page, server}) { it('should report multiple scripts', async function({page, server}) {
await page.coverage.startJSCoverage(); await page.coverage.startJSCoverage();