From 3fc8da99554cfeb4738fd2a33c683784ff3c2f49 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Dar=C3=ADo=20Kondratiuk?= <dariokondratiuk@gmail.com>
Date: Wed, 20 Sep 2023 10:58:30 -0300
Subject: [PATCH] refactor: reuse otherTarget on createTarget (#10957)

---
 packages/puppeteer-core/src/cdp/Browser.ts | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/packages/puppeteer-core/src/cdp/Browser.ts b/packages/puppeteer-core/src/cdp/Browser.ts
index 207600b7675..60a953c86f4 100644
--- a/packages/puppeteer-core/src/cdp/Browser.ts
+++ b/packages/puppeteer-core/src/cdp/Browser.ts
@@ -275,7 +275,7 @@ export class CdpBrowser extends BrowserBase {
     const createSession = (isAutoAttachEmulated: boolean) => {
       return this.#connection._createSession(targetInfo, isAutoAttachEmulated);
     };
-    const targetForFilter = new OtherTarget(
+    const otherTarget = new OtherTarget(
       targetInfo,
       session,
       context,
@@ -294,7 +294,7 @@ export class CdpBrowser extends BrowserBase {
         this.#screenshotTaskQueue
       );
     }
-    if (this.#isPageTargetCallback(targetForFilter)) {
+    if (this.#isPageTargetCallback(otherTarget)) {
       return new PageTarget(
         targetInfo,
         session,
@@ -318,13 +318,7 @@ export class CdpBrowser extends BrowserBase {
         createSession
       );
     }
-    return new OtherTarget(
-      targetInfo,
-      session,
-      context,
-      this.#targetManager,
-      createSession
-    );
+    return otherTarget;
   };
 
   #onAttachedToTarget = async (target: CdpTarget) => {