diff --git a/docs/api/puppeteer.browsercontext.waitfortarget.md b/docs/api/puppeteer.browsercontext.waitfortarget.md index 4ef830f63bd..085c046ad24 100644 --- a/docs/api/puppeteer.browsercontext.waitfortarget.md +++ b/docs/api/puppeteer.browsercontext.waitfortarget.md @@ -21,10 +21,10 @@ class BrowserContext { ## Parameters -| Parameter | Type | Description | -| --------- | ---------------------------------------------------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | -| predicate | (x: [Target](./puppeteer.target.md)) => boolean \| Promise<boolean> | A function to be run for every target | -| options | { timeout?: number; } | (Optional) An object of options. Accepts a timout, which is the maximum wait time in milliseconds. Pass 0 to disable the timeout. Defaults to 30 seconds. | +| Parameter | Type | Description | +| --------- | ---------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ | +| predicate | (x: [Target](./puppeteer.target.md)) => boolean \| Promise<boolean> | A function to be run for every target | +| options | { timeout?: number; } | (Optional) An object of options. Accepts a timeout, which is the maximum wait time in milliseconds. Pass 0 to disable the timeout. Defaults to 30 seconds. | **Returns:** diff --git a/docs/api/puppeteer.frame.waitforxpath.md b/docs/api/puppeteer.frame.waitforxpath.md index fdcea726006..5baa65c6ee9 100644 --- a/docs/api/puppeteer.frame.waitforxpath.md +++ b/docs/api/puppeteer.frame.waitforxpath.md @@ -29,10 +29,10 @@ class Frame { ## Parameters -| Parameter | Type | Description | -| --------- | --------------------------------------------------------------- | ----------------------------------------------------------------------------------------------------------- | -| xpath | string | the XPath expression to wait for. | -| options | [WaitForSelectorOptions](./puppeteer.waitforselectoroptions.md) | (Optional) options to configure the visiblity of the element and how long to wait before timing out. | +| Parameter | Type | Description | +| --------- | --------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------ | +| xpath | string | the XPath expression to wait for. | +| options | [WaitForSelectorOptions](./puppeteer.waitforselectoroptions.md) | (Optional) options to configure the visibility of the element and how long to wait before timing out. | **Returns:** diff --git a/packages/ng-schematics/README.md b/packages/ng-schematics/README.md index fb374039138..39c44946497 100644 --- a/packages/ng-schematics/README.md +++ b/packages/ng-schematics/README.md @@ -4,14 +4,14 @@ Adds Puppeteer-based e2e tests to your Angular project. ## Usage -Run the command bellow in an Angular CLI app directory and follow the prompts. +Run the command below in an Angular CLI app directory and follow the prompts. _Note this will add the schematic as a dependency to your project._ ```bash ng add @puppeteer/ng-schematics ``` -Or you can use the same command followed by the [options](#options) bellow. +Or you can use the same command followed by the [options](#options) below. Currently, this schematic supports the following test frameworks: diff --git a/packages/puppeteer-core/src/api/BrowserContext.ts b/packages/puppeteer-core/src/api/BrowserContext.ts index 56868760db7..097905cc81c 100644 --- a/packages/puppeteer-core/src/api/BrowserContext.ts +++ b/packages/puppeteer-core/src/api/BrowserContext.ts @@ -83,7 +83,7 @@ export class BrowserContext extends EventEmitter { * ``` * * @param predicate - A function to be run for every target - * @param options - An object of options. Accepts a timout, + * @param options - An object of options. Accepts a timeout, * which is the maximum wait time in milliseconds. * Pass `0` to disable the timeout. Defaults to 30 seconds. * @returns Promise which resolves to the first target found diff --git a/packages/puppeteer-core/src/api/Page.ts b/packages/puppeteer-core/src/api/Page.ts index 2fbeb388a38..8ceb638a2be 100644 --- a/packages/puppeteer-core/src/api/Page.ts +++ b/packages/puppeteer-core/src/api/Page.ts @@ -263,7 +263,7 @@ export const enum PageEmittedEvents { * Contains an object with two properties: * * - `title`: the title passed to `console.timeStamp` - * - `metrics`: objec containing metrics as key/value pairs. The values will + * - `metrics`: object containing metrics as key/value pairs. The values will * be `number`s. */ Metrics = 'metrics', diff --git a/packages/puppeteer-core/src/common/Browser.ts b/packages/puppeteer-core/src/common/Browser.ts index c3052e7a7af..5b3232c4b47 100644 --- a/packages/puppeteer-core/src/common/Browser.ts +++ b/packages/puppeteer-core/src/common/Browser.ts @@ -623,7 +623,7 @@ export class CDPBrowserContext extends BrowserContext { * ``` * * @param predicate - A function to be run for every target - * @param options - An object of options. Accepts a timout, + * @param options - An object of options. Accepts a timeout, * which is the maximum wait time in milliseconds. * Pass `0` to disable the timeout. Defaults to 30 seconds. * @returns Promise which resolves to the first target found diff --git a/packages/puppeteer-core/src/common/Frame.ts b/packages/puppeteer-core/src/common/Frame.ts index ae679f4e232..63a280759cc 100644 --- a/packages/puppeteer-core/src/common/Frame.ts +++ b/packages/puppeteer-core/src/common/Frame.ts @@ -629,7 +629,7 @@ export class Frame { * an XPath. * * @param xpath - the XPath expression to wait for. - * @param options - options to configure the visiblity of the element and how + * @param options - options to configure the visibility of the element and how * long to wait before timing out. */ async waitForXPath( diff --git a/packages/puppeteer-core/src/common/IsolatedWorld.ts b/packages/puppeteer-core/src/common/IsolatedWorld.ts index 24806e5c5c1..13a22555cb8 100644 --- a/packages/puppeteer-core/src/common/IsolatedWorld.ts +++ b/packages/puppeteer-core/src/common/IsolatedWorld.ts @@ -474,7 +474,7 @@ export class IsolatedWorld { ); } catch (error) { // The WaitTask may already have been resolved by timing out, or the - // exection context may have been destroyed. + // execution context may have been destroyed. // In both caes, the promises above are rejected with a protocol error. // We can safely ignores these, as the WaitTask is re-installed in // the next execution context if needed. diff --git a/packages/puppeteer-core/src/common/bidi/BidiOverCDP.ts b/packages/puppeteer-core/src/common/bidi/BidiOverCDP.ts index fbef6881c13..d3c9d89487d 100644 --- a/packages/puppeteer-core/src/common/bidi/BidiOverCDP.ts +++ b/packages/puppeteer-core/src/common/bidi/BidiOverCDP.ts @@ -26,7 +26,7 @@ export async function connectBidiOverCDP( cdpConnectionAdapter.close(); }, onmessage(_message: string): void { - // The method is overriden by the Connection. + // The method is overridden by the Connection. }, }; transportBiDi.on('bidiResponse', (message: object) => { @@ -63,7 +63,7 @@ class CDPConnectionAdapter { getCdpClient(id: string) { const session = this.#cdp.session(id); if (!session) { - throw new Error('Unknonw CDP session with id' + id); + throw new Error('Unknown CDP session with id' + id); } if (!this.#adapters.has(session)) { const adapter = new CDPClientAdapter(session); @@ -82,7 +82,7 @@ class CDPConnectionAdapter { } /** - * Wrapper on top of CDPSession/CDPConnection to satisify CDP interface that + * Wrapper on top of CDPSession/CDPConnection to satisfy CDP interface that * BidiServer needs. * * @internal diff --git a/packages/puppeteer-core/src/common/types.ts b/packages/puppeteer-core/src/common/types.ts index 2317a91f1ba..ed30e735238 100644 --- a/packages/puppeteer-core/src/common/types.ts +++ b/packages/puppeteer-core/src/common/types.ts @@ -174,8 +174,8 @@ type FlatmapSplitWithDelemiters< type Split< Input extends string, - Delemiter extends string, + Delimiter extends string, Acc extends string[] = [] -> = Input extends `${infer Prefix}${Delemiter}${infer Suffix}` - ? Split +> = Input extends `${infer Prefix}${Delimiter}${infer Suffix}` + ? Split : [...Acc, Input]; diff --git a/test/src/cookies.spec.ts b/test/src/cookies.spec.ts index 6cf1ba1686b..5f51c76f101 100644 --- a/test/src/cookies.spec.ts +++ b/test/src/cookies.spec.ts @@ -377,7 +377,7 @@ describe('Cookie specs', () => { const [cookie] = await page.cookies(SECURE_URL); expect(cookie!.secure).toBe(true); }); - it('should be able to set unsecure cookie for HTTP website', async () => { + it('should be able to set insecure cookie for HTTP website', async () => { const {page, server} = getTestState(); await page.goto(server.EMPTY_PAGE); diff --git a/test/src/oopif.spec.ts b/test/src/oopif.spec.ts index eb2eb5e0861..9c82fe1f065 100644 --- a/test/src/oopif.spec.ts +++ b/test/src/oopif.spec.ts @@ -233,7 +233,7 @@ describeWithDebugLogs('OOPIF', function () { if (!isHeadless || headless === 'new') { // TODO: this test is partially blocked on crbug.com/1334119. Enable test once // the upstream is fixed. - // TLDR: when we dispatch events ot the frame the compositor might + // TLDR: when we dispatch events to the frame the compositor might // not be up-to-date yet resulting in a misclick (the iframe element // becomes the event target instead of the content inside the iframe). // The solution is to use InsertVisualCallback on the backend but that causes diff --git a/tools/mochaRunner/src/interface.ts b/tools/mochaRunner/src/interface.ts index df48855bbca..00c03049a2f 100644 --- a/tools/mochaRunner/src/interface.ts +++ b/tools/mochaRunner/src/interface.ts @@ -33,14 +33,14 @@ function shouldSkipTest(test: Mocha.Test): boolean { const testIdForFileName = getTestId(test.file!); const testIdForTestName = getTestId(test.file!, test.fullTitle()); // TODO: more efficient lookup. - const defintion = skippedTests.find(skippedTest => { + const definition = skippedTests.find(skippedTest => { return ( '' === skippedTest.testIdPattern || testIdForFileName === skippedTest.testIdPattern || testIdForTestName === skippedTest.testIdPattern ); }); - if (defintion && defintion.skip) { + if (definition && definition.skip) { return true; } return false;