github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(Chromium): roll Chromium to r549031 (#2327)

Browse Source 
This roll includes:
- https://crrev.com/549003 - DevTools: make pptr tests pass with DCHECKs.

The patch fixes a browser crash that happens during browser close.
As a result, cookies were not saved properly (and thus the flaky test we
had).

Fixes #1537.
This commit is contained in:
Andrey Lushnikov 2018-04-06 21:53:25 -07:00 committed by GitHub
parent 8c54f41552
commit 45d97e572a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
package.json
View File

@ -36,7 +36,7 @@
"ws": "^3.0.0" "ws": "^3.0.0"
}, },
"puppeteer": { "puppeteer": {
"chromium_revision": "548921" "chromium_revision": "549031"
}, },
"devDependencies": { "devDependencies": {
"@types/debug": "0.0.30", "@types/debug": "0.0.30",

3
test/puppeteer.spec.js
View File

@ -145,8 +145,7 @@ module.exports.addTests = function({testRunner, expect, defaultBrowserOptions, p
await browser2.close(); await browser2.close();
rm(userDataDir); rm(userDataDir);
}); });
// @see https://github.com/GoogleChrome/puppeteer/issues/1537 it('userDataDir option should restore cookies', async({server}) => {
xit('userDataDir option should restore cookies', async({server}) => {
const userDataDir = await mkdtempAsync(TMP_FOLDER); const userDataDir = await mkdtempAsync(TMP_FOLDER);
const options = Object.assign({userDataDir}, defaultBrowserOptions); const options = Object.assign({userDataDir}, defaultBrowserOptions);
const browser = await puppeteer.launch(options); const browser = await puppeteer.launch(options);