github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: disable IsolateSandboxedIframes trial to prevent flakiness (#12381)

Browse Source
This commit is contained in:
Alex Rudenko 2024-05-02 15:55:15 +02:00 committed by GitHub
parent f7e44b9742
commit 461a8ff92f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 9 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
packages/puppeteer-core/src/node/ChromeLauncher.ts
View File

@ -176,10 +176,15 @@ export class ChromeLauncher extends ProductLauncher {
'AcceptCHFrame', 'AcceptCHFrame',
'MediaRouter', 'MediaRouter',
'OptimizationHints', 'OptimizationHints',
...(turnOnExperimentalFeaturesForTesting
? []
: [
// https://crbug.com/1492053 // https://crbug.com/1492053
turnOnExperimentalFeaturesForTesting 'ProcessPerSiteUpToMainFrameThreshold',
? '' // https://github.com/puppeteer/puppeteer/issues/10715
: 'ProcessPerSiteUpToMainFrameThreshold', 'IsolateSandboxedIframes',
]),
...userDisabledFeatures, ...userDisabledFeatures,
].filter(feature => { ].filter(feature => {
return feature !== ''; return feature !== '';

7
test/TestExpectations.json
View File

@ -1442,13 +1442,6 @@
"expectations": ["FAIL"], "expectations": ["FAIL"],
"comment": "TODO: add a comment explaining why this expectation is required (include links to issues)" "comment": "TODO: add a comment explaining why this expectation is required (include links to issues)"
}, },
{
"testIdPattern": "[elementhandle.spec] ElementHandle specs ElementHandle.clickablePoint should work for iframes",
"platforms": ["linux", "win32", "win32"],
"parameters": ["cdp", "chrome"],
"expectations": ["FAIL", "PASS"],
"comment": "Flaky with fieldtrial testing config"
},
{ {
"testIdPattern": "[elementhandle.spec] ElementHandle specs ElementHandle.isIntersectingViewport should work", "testIdPattern": "[elementhandle.spec] ElementHandle specs ElementHandle.isIntersectingViewport should work",
"platforms": ["darwin", "linux", "win32"], "platforms": ["darwin", "linux", "win32"],