chore: remove commitlint and husky (#10304)

This commit is contained in:
Alex Rudenko 2023-06-02 13:17:20 +02:00 committed by GitHub
parent 4d4e4bc892
commit 4764b9a079
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
7 changed files with 2 additions and 1376 deletions

View File

@ -41,9 +41,6 @@ jobs:
run: npm run lint run: npm run lint
- name: Validate licenses - name: Validate licenses
run: npm run validate-licenses run: npm run validate-licenses
- name: Lint commits
run: npm run commitlint
if: github.event_name != 'pull_request'
- name: Build every package - name: Build every package
run: npm run build run: npm run build
- name: Generate documents - name: Generate documents

View File

@ -1,4 +0,0 @@
#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"
npx commitlint --edit "$1"

View File

@ -1,28 +0,0 @@
/**
* Copyright 2020 Google Inc. All rights reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
// See https://github.com/conventional-changelog/commitlint/blob/master/docs/reference-rules.md
module.exports = {
extends: ['@commitlint/config-conventional'],
rules: {
// Override. The subject may be the name of a class.
'subject-case': [0],
// Override. Most UIs wrap the body.
'body-max-line-length': [0],
// Override. Most UIs wrap the footer.
'footer-max-line-length': [0],
},
};

View File

@ -123,8 +123,7 @@ Our coding style is fully defined in
[`.prettierrc.cjs`](https://github.com/puppeteer/puppeteer/blob/main/.prettierrc.cjs) [`.prettierrc.cjs`](https://github.com/puppeteer/puppeteer/blob/main/.prettierrc.cjs)
([Prettier](https://prettier.io)). ([Prettier](https://prettier.io)).
Code is checked during `pre-push` using Code is checked for PRs automatically and you can check your code
[Husky](https://typicode.github.io/husky/#/), but you can check your code
manually by running: manually by running:
```bash ```bash
@ -165,7 +164,6 @@ When authoring new API methods, consider the following:
Commit messages should follow Commit messages should follow
[the Conventional Commits format](https://www.conventionalcommits.org/en/v1.0.0/#summary). [the Conventional Commits format](https://www.conventionalcommits.org/en/v1.0.0/#summary).
This is enforced via `npm run commitlint`.
In particular, breaking changes should clearly be noted as “BREAKING CHANGE:” in In particular, breaking changes should clearly be noted as “BREAKING CHANGE:” in
the commit message footer. Example: the commit message footer. Example:

1329
package-lock.json generated

File diff suppressed because it is too large Load Diff

View File

@ -11,7 +11,6 @@
"check:pinned-deps": "tsx tools/ensure-pinned-deps", "check:pinned-deps": "tsx tools/ensure-pinned-deps",
"check": "npm run check --workspaces --if-present && run-p check:*", "check": "npm run check --workspaces --if-present && run-p check:*",
"clean": "rimraf -g \"./**/.wireit\" && npm run clean --workspaces --if-present", "clean": "rimraf -g \"./**/.wireit\" && npm run clean --workspaces --if-present",
"commitlint": "commitlint --from=HEAD~1",
"debug": "mocha --inspect-brk", "debug": "mocha --inspect-brk",
"docs": "run-s build:docs generate:markdown", "docs": "run-s build:docs generate:markdown",
"format:eslint": "eslint --ext js --ext ts --fix .", "format:eslint": "eslint --ext js --ext ts --fix .",
@ -23,7 +22,6 @@
"lint:prettier": "prettier --check .", "lint:prettier": "prettier --check .",
"lint": "run-s lint:prettier lint:eslint", "lint": "run-s lint:prettier lint:eslint",
"postinstall": "npm run postinstall --workspaces --if-present", "postinstall": "npm run postinstall --workspaces --if-present",
"prepare": "husky install",
"test-install": "npm run test --workspace @puppeteer-test/installation", "test-install": "npm run test --workspace @puppeteer-test/installation",
"test-types": "tsd -t packages/puppeteer", "test-types": "tsd -t packages/puppeteer",
"test:chrome:headful": "wireit", "test:chrome:headful": "wireit",
@ -124,8 +122,6 @@
}, },
"devDependencies": { "devDependencies": {
"@actions/core": "1.10.0", "@actions/core": "1.10.0",
"@commitlint/cli": "17.6.1",
"@commitlint/config-conventional": "17.6.1",
"@microsoft/api-documenter": "7.22.7", "@microsoft/api-documenter": "7.22.7",
"@microsoft/api-extractor": "7.35.1", "@microsoft/api-extractor": "7.35.1",
"@microsoft/api-extractor-model": "7.27.1", "@microsoft/api-extractor-model": "7.27.1",
@ -149,7 +145,6 @@
"@typescript-eslint/eslint-plugin": "5.59.1", "@typescript-eslint/eslint-plugin": "5.59.1",
"@typescript-eslint/parser": "5.59.1", "@typescript-eslint/parser": "5.59.1",
"c8": "7.13.0", "c8": "7.13.0",
"commitlint": "17.6.1",
"commonmark": "0.30.0", "commonmark": "0.30.0",
"cross-env": "7.0.3", "cross-env": "7.0.3",
"diff": "5.1.0", "diff": "5.1.0",
@ -167,7 +162,6 @@
"expect": "29.4.3", "expect": "29.4.3",
"glob": "8.1.0", "glob": "8.1.0",
"gts": "4.0.1", "gts": "4.0.1",
"husky": "8.0.3",
"jpeg-js": "0.4.4", "jpeg-js": "0.4.4",
"license-checker": "25.0.1", "license-checker": "25.0.1",
"mime": "3.0.0", "mime": "3.0.0",

View File

@ -123,8 +123,7 @@ Our coding style is fully defined in
[`.prettierrc.cjs`](https://github.com/puppeteer/puppeteer/blob/main/.prettierrc.cjs) [`.prettierrc.cjs`](https://github.com/puppeteer/puppeteer/blob/main/.prettierrc.cjs)
([Prettier](https://prettier.io)). ([Prettier](https://prettier.io)).
Code is checked during `pre-push` using Code is checked for PRs automatically and you can check your code
[Husky](https://typicode.github.io/husky/#/), but you can check your code
manually by running: manually by running:
```bash ```bash
@ -165,7 +164,6 @@ When authoring new API methods, consider the following:
Commit messages should follow Commit messages should follow
[the Conventional Commits format](https://www.conventionalcommits.org/en/v1.0.0/#summary). [the Conventional Commits format](https://www.conventionalcommits.org/en/v1.0.0/#summary).
This is enforced via `npm run commitlint`.
In particular, breaking changes should clearly be noted as “BREAKING CHANGE:” in In particular, breaking changes should clearly be noted as “BREAKING CHANGE:” in
the commit message footer. Example: the commit message footer. Example: