diff --git a/package-lock.json b/package-lock.json index 9ac62fd7238..bb7e9a19b1c 100644 --- a/package-lock.json +++ b/package-lock.json @@ -3953,9 +3953,9 @@ } }, "node_modules/devtools-protocol": { - "version": "0.0.1159816", - "resolved": "https://registry.npmjs.org/devtools-protocol/-/devtools-protocol-0.0.1159816.tgz", - "integrity": "sha512-2cZlHxC5IlgkIWe2pSDmCrDiTzbSJWywjbDDnupOImEBcG31CQgBLV8wWE+5t+C4rimcjHsbzy7CBzf9oFjboA==" + "version": "0.0.1179426", + "resolved": "https://registry.npmjs.org/devtools-protocol/-/devtools-protocol-0.0.1179426.tgz", + "integrity": "sha512-KKC7IGwdOr7u9kTGgjUvGTov/z1s2H7oHi3zKCdR9eSDyCPia5CBi4aRhtp7d8uR7l0GS5UTDw3TjKGu5CqINg==" }, "node_modules/dezalgo": { "version": "1.0.4", @@ -11117,7 +11117,7 @@ "chromium-bidi": "0.4.27", "cross-fetch": "4.0.0", "debug": "4.3.4", - "devtools-protocol": "0.0.1159816", + "devtools-protocol": "0.0.1179426", "ws": "8.14.1" }, "devDependencies": { @@ -13779,9 +13779,9 @@ "dev": true }, "devtools-protocol": { - "version": "0.0.1159816", - "resolved": "https://registry.npmjs.org/devtools-protocol/-/devtools-protocol-0.0.1159816.tgz", - "integrity": "sha512-2cZlHxC5IlgkIWe2pSDmCrDiTzbSJWywjbDDnupOImEBcG31CQgBLV8wWE+5t+C4rimcjHsbzy7CBzf9oFjboA==" + "version": "0.0.1179426", + "resolved": "https://registry.npmjs.org/devtools-protocol/-/devtools-protocol-0.0.1179426.tgz", + "integrity": "sha512-KKC7IGwdOr7u9kTGgjUvGTov/z1s2H7oHi3zKCdR9eSDyCPia5CBi4aRhtp7d8uR7l0GS5UTDw3TjKGu5CqINg==" }, "dezalgo": { "version": "1.0.4", @@ -17251,7 +17251,7 @@ "chromium-bidi": "0.4.27", "cross-fetch": "4.0.0", "debug": "4.3.4", - "devtools-protocol": "0.0.1159816", + "devtools-protocol": "0.0.1179426", "disposablestack": "1.1.1", "mitt": "3.0.1", "parsel-js": "1.1.2", diff --git a/package.json b/package.json index c908b141203..fcebd225f8c 100644 --- a/package.json +++ b/package.json @@ -27,6 +27,7 @@ "test-types": "tsd -t packages/puppeteer", "test:chrome:headful": "wireit", "test:chrome:new-headless": "wireit", + "test:chrome:new-headless-tab": "wireit", "test:chrome:headless": "wireit", "test:chrome:bidi": "wireit", "test:chrome:bidi-local": "wireit", @@ -67,6 +68,9 @@ "test:chrome:new-headless": { "command": "npm test -- --test-suite chrome-new-headless" }, + "test:chrome:new-headless-tab": { + "command": "npm test -- --test-suite chrome-new-headless-tab" + }, "test:chrome:bidi": { "command": "npm test -- --test-suite chrome-bidi" }, diff --git a/packages/puppeteer-core/package.json b/packages/puppeteer-core/package.json index 9d6fabf643d..0d46af64de0 100644 --- a/packages/puppeteer-core/package.json +++ b/packages/puppeteer-core/package.json @@ -144,7 +144,7 @@ "chromium-bidi": "0.4.27", "cross-fetch": "4.0.0", "debug": "4.3.4", - "devtools-protocol": "0.0.1159816", + "devtools-protocol": "0.0.1179426", "ws": "8.14.1" }, "devDependencies": { diff --git a/packages/puppeteer-core/src/common/Accessibility.ts b/packages/puppeteer-core/src/common/Accessibility.ts index f059850208a..82f0e2552ff 100644 --- a/packages/puppeteer-core/src/common/Accessibility.ts +++ b/packages/puppeteer-core/src/common/Accessibility.ts @@ -353,6 +353,7 @@ class AXNode { case 'doc-cover': case 'graphics-symbol': case 'img': + case 'image': case 'Meter': case 'scrollbar': case 'slider': diff --git a/packages/puppeteer-core/src/common/AriaQueryHandler.ts b/packages/puppeteer-core/src/common/AriaQueryHandler.ts index 9c828cea9ef..e0f8bdd802c 100644 --- a/packages/puppeteer-core/src/common/AriaQueryHandler.ts +++ b/packages/puppeteer-core/src/common/AriaQueryHandler.ts @@ -64,7 +64,7 @@ const normalizeValue = (value: string): string => { * The following examples showcase how the syntax works wrt. querying: * * - 'title[role="heading"]' queries for elements with name 'title' and role 'heading'. - * - '[role="img"]' queries for elements with role 'img' and any name. + * - '[role="image"]' queries for elements with role 'image' and any name. * - 'label' queries for elements with name 'label' and any role. * - '[name=""][role="button"]' queries for elements with no name and role 'button'. */ diff --git a/packages/puppeteer-core/src/common/NetworkManager.test.ts b/packages/puppeteer-core/src/common/NetworkManager.test.ts index 131e6787793..a63652ce18a 100644 --- a/packages/puppeteer-core/src/common/NetworkManager.test.ts +++ b/packages/puppeteer-core/src/common/NetworkManager.test.ts @@ -675,7 +675,6 @@ describe('NetworkManager', () => { requestId: '1360.2', timestamp: 10959.060708, encodedDataLength: 85928, - shouldReportCorbBlocking: false, }); expect(requests).toHaveLength(1); @@ -802,7 +801,6 @@ describe('NetworkManager', () => { requestId: 'LOADERID', timestamp: 671.234448, encodedDataLength: 197, - shouldReportCorbBlocking: false, }); expect(pendingRequests).toHaveLength(1); @@ -1115,7 +1113,6 @@ describe('NetworkManager', () => { requestId: 'E18BEB94B486CA8771F9AFA2030FEA37', timestamp: 510294.113383, encodedDataLength: 197, - shouldReportCorbBlocking: false, }); mockCDPSession.emit('Network.responseReceivedExtraInfo', { requestId: 'E18BEB94B486CA8771F9AFA2030FEA37', @@ -1283,7 +1280,6 @@ describe('NetworkManager', () => { requestId: '6D76C8ACAECE880C722FA515AD380015', timestamp: 31949.963861, encodedDataLength: 847, - shouldReportCorbBlocking: false, }); mockCDPSession.emit('Network.requestWillBeSent', { @@ -1534,7 +1530,6 @@ describe('NetworkManager', () => { requestId: '4C2CC44FB6A6CAC5BE2780BCC9313105', timestamp: 31949.989412, encodedDataLength: 0, - shouldReportCorbBlocking: false, }); expect( responses.map(r => { diff --git a/packages/puppeteer-core/src/revisions.ts b/packages/puppeteer-core/src/revisions.ts index 512d8342d7c..b61dc5f91e0 100644 --- a/packages/puppeteer-core/src/revisions.ts +++ b/packages/puppeteer-core/src/revisions.ts @@ -18,6 +18,6 @@ * @internal */ export const PUPPETEER_REVISIONS = Object.freeze({ - chrome: '116.0.5845.96', + chrome: '117.0.5938.62', firefox: 'latest', }); diff --git a/test/TestExpectations.json b/test/TestExpectations.json index da977205e69..d781b4e5ebe 100644 --- a/test/TestExpectations.json +++ b/test/TestExpectations.json @@ -1347,7 +1347,7 @@ "testIdPattern": "[accessibility.spec] Accessibility filtering children of leaf nodes rich text editable fields should have children", "platforms": ["darwin", "linux", "win32"], "parameters": ["chrome", "webDriverBiDi"], - "expectations": ["FAIL"] + "expectations": ["PASS"] }, { "testIdPattern": "[accessibility.spec] Accessibility get snapshots while the tree is re-calculated", @@ -4084,5 +4084,11 @@ "platforms": ["darwin", "linux", "win32"], "parameters": ["cdp", "chrome", "headless"], "expectations": ["FAIL", "PASS"] + }, + { + "testIdPattern": "[coverage.spec] Coverage specs JSCoverage resetOnNavigation should report scripts across navigations when disabled", + "platforms": ["darwin", "linux", "win32"], + "parameters": ["chrome", "new-headless", "cdp", "tabTarget"], + "expectations": ["FAIL"] } ] diff --git a/test/src/accessibility.spec.ts b/test/src/accessibility.spec.ts index 051ef1702d6..ce5f17f0652 100644 --- a/test/src/accessibility.spec.ts +++ b/test/src/accessibility.spec.ts @@ -338,7 +338,7 @@ describe('Accessibility', function () { name: 'Edit this image: ', }, { - role: 'img', + role: 'image', name: 'my fake image', }, ], diff --git a/test/src/ariaqueryhandler.spec.ts b/test/src/ariaqueryhandler.spec.ts index 25161563122..cf401014c24 100644 --- a/test/src/ariaqueryhandler.spec.ts +++ b/test/src/ariaqueryhandler.spec.ts @@ -390,7 +390,7 @@ describe('AriaQueryHandler', () => { let imgFound = false; const waitForSelector = page - .waitForSelector('aria/[role="img"]') + .waitForSelector('aria/[role="image"]') .then(() => { return (imgFound = true); }); diff --git a/versions.js b/versions.js index 0f194938d2e..0fd3f176f80 100644 --- a/versions.js +++ b/versions.js @@ -17,6 +17,7 @@ const versionsPerRelease = new Map([ // This is a mapping from Chrome version => Puppeteer version. // In Chrome roll patches, use `NEXT` for the Puppeteer version. + ['117.0.5938.62', 'NEXT'], ['116.0.5845.96', 'v21.1.0'], ['115.0.5790.170', 'v21.0.2'], ['115.0.5790.102', 'v21.0.0'], @@ -65,7 +66,7 @@ const versionsPerRelease = new Map([ ]); // Should not be more than 2 major versions behind Chrome Stable (https://chromestatus.com/roadmap). -const lastMaintainedChromeVersion = '114.0.5735.90'; +const lastMaintainedChromeVersion = '114.0.5735.133'; if (!versionsPerRelease.has(lastMaintainedChromeVersion)) { throw new Error(