From 52d3bc05dea670e087afced923e288e4633c09b2 Mon Sep 17 00:00:00 2001
From: Juan Sebastian velez Posada <jvelezpo@users.noreply.github.com>
Date: Mon, 12 Mar 2018 18:38:05 -0400
Subject: [PATCH] feat(Page): introduce url at error message at page.goto
 (#2174)

Now the error message will come with the url where the error was
generated.

Fixes #2165.
---
 lib/Page.js  |  2 +-
 test/test.js | 10 ++++++++++
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/lib/Page.js b/lib/Page.js
index c30f42d5e51..0b5efb68dc7 100644
--- a/lib/Page.js
+++ b/lib/Page.js
@@ -518,7 +518,7 @@ class Page extends EventEmitter {
     async function navigate(client, url, referrer) {
       try {
         const response = await client.send('Page.navigate', {url, referrer});
-        return response.errorText ? new Error(response.errorText) : null;
+        return response.errorText ? new Error(`${response.errorText} at ${url}`) : null;
       } catch (error) {
         return error;
       }
diff --git a/test/test.js b/test/test.js
index 7d2c54b4eb7..d9b446de3c8 100644
--- a/test/test.js
+++ b/test/test.js
@@ -1420,6 +1420,16 @@ describe('Page', function() {
       expect(response.status()).toBe(200);
       expect(response.url()).toContain('self-request.html');
     });
+    it('should fail when navigating and show the url at the error message', async function({page, server, httpsServer}) {
+      const url = httpsServer.PREFIX + '/redirect/1.html';
+      let error = null;
+      try {
+        await page.goto(url);
+      } catch (e) {
+        error = e;
+      }
+      expect(error.message).toContain(url);
+    });
   });
 
   describe('Page.waitForNavigation', function() {