Remove the Page.setBlockedURLs method

This patch removes the Page.setBlockedURLs method. The
functionality is trivially implementable with the request
interception (see examples/loadurlwithoutcss.js).

Fixes #1.
This commit is contained in:
Andrey Lushnikov 2017-06-15 08:23:48 -07:00
parent 85ecce31f9
commit 5ba6621cde
3 changed files with 6 additions and 20 deletions

View File

@ -7,7 +7,6 @@
- [browser.version()](#browserversion) - [browser.version()](#browserversion)
- [browser.close()](#browserclose) - [browser.close()](#browserclose)
- [class: Page](#class-page) - [class: Page](#class-page)
- [page.setBlockedURLs(patterns)](#pagesetblockedurlspatterns)
- [page.addScriptTag(url)](#pageaddscripttagurl) - [page.addScriptTag(url)](#pageaddscripttagurl)
- [page.injectFile(filePath)](#pageinjectfilefilepath) - [page.injectFile(filePath)](#pageinjectfilefilepath)
- [page.setInPageCallback(name, callback)](#pagesetinpagecallbackname-callback) - [page.setInPageCallback(name, callback)](#pagesetinpagecallbackname-callback)
@ -75,11 +74,6 @@ browser.newPage().then(page => {
``` ```
Pages could be closed by `page.close()` method. Pages could be closed by `page.close()` method.
#### page.setBlockedURLs(patterns)
- `patterns` [<Array>](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array)
- returns: [<Promise>](https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/Promise) Promise which resolves when blocked URLs have been successfully set.
#### page.addScriptTag(url) #### page.addScriptTag(url)
- `url` [<string>](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Data_structures#String_type) Url of a script to be added - `url` [<string>](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Data_structures#String_type) Url of a script to be added

View File

@ -25,7 +25,12 @@ var address = process.argv[2];
var browser = new Browser({headless: false}); var browser = new Browser({headless: false});
browser.newPage().then(async page => { browser.newPage().then(async page => {
await page.setBlockedURLs(['*.css']); page.setRequestInterceptor(request => {
if (request.url().endsWith('.css'))
request.abort();
else
request.continue();
});
var success = await page.navigate(address); var success = await page.navigate(address);
if (!success) if (!success)
console.log('Unable to load the address!'); console.log('Unable to load the address!');

View File

@ -55,8 +55,6 @@ class Page extends EventEmitter {
this._sourceURLToPageCallback = new Map(); this._sourceURLToPageCallback = new Map();
/** @type {!Map<string, !InPageCallback>} */ /** @type {!Map<string, !InPageCallback>} */
this._scriptIdToPageCallback = new Map(); this._scriptIdToPageCallback = new Map();
/** @type {!Array<string>} */
this._blockedURLs = [];
/** @type {?function(!Request)} */ /** @type {?function(!Request)} */
this._requestInterceptor = null; this._requestInterceptor = null;
@ -86,17 +84,6 @@ class Page extends EventEmitter {
this._requestInterceptor(request); this._requestInterceptor(request);
} }
/**
* @param {!Array<string>} patterns
* @return {!Promise}
*/
async setBlockedURLs(patterns) {
this._blockedURLs = patterns;
await this._client.send('Network.setBlockedURLs', {
urls: patterns
});
}
/** /**
* @param {string} url * @param {string} url
* @return {!Promise} * @return {!Promise}