From 63d9ac4df81d4e44edb1b1f15dcd4053329642c3 Mon Sep 17 00:00:00 2001 From: Andrey Lushnikov Date: Mon, 28 Jan 2019 14:20:28 -0800 Subject: [PATCH] fix(executioncontext): follow up to properly adopt element handles (#3857) The `executionContextId` argument was missing, which made all element handles to resolve in the main world. All our tests pass atm, but this would've fired back when we exposed extension execution contexts. --- lib/ExecutionContext.js | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/ExecutionContext.js b/lib/ExecutionContext.js index d1217a2f959..2a6c9ac2274 100644 --- a/lib/ExecutionContext.js +++ b/lib/ExecutionContext.js @@ -186,6 +186,7 @@ class ExecutionContext { }); const {object} = await this._client.send('DOM.resolveNode', { backendNodeId: nodeInfo.node.backendNodeId, + executionContextId: this._contextId, }); return /** @type {Puppeteer.ElementHandle}*/(createJSHandle(this, object)); }