github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: negative timeout doesn't break launch (#10480)

Browse Source
This commit is contained in:
Nikolay Vitkov 2023-06-29 17:34:20 +02:00 committed by GitHub
parent 25cb642623
commit 6a89a2aadc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/browsers/src/launch.ts
View File

@ -368,7 +368,7 @@ export class Process {
this.#clearListeners(); this.#clearListeners();
} }
waitForLineOutput(regex: RegExp, timeout?: number): Promise<string> { waitForLineOutput(regex: RegExp, timeout = 0): Promise<string> {
if (!this.#browserProcess.stderr) { if (!this.#browserProcess.stderr) {
throw new Error('`browserProcess` does not have stderr.'); throw new Error('`browserProcess` does not have stderr.');
} }
@ -380,7 +380,8 @@ export class Process {
rl.on('close', onClose); rl.on('close', onClose);
this.#browserProcess.on('exit', onClose); this.#browserProcess.on('exit', onClose);
this.#browserProcess.on('error', onClose); this.#browserProcess.on('error', onClose);
const timeoutId = timeout ? setTimeout(onTimeout, timeout) : 0; const timeoutId =
timeout > 0 ? setTimeout(onTimeout, timeout) : undefined;
const cleanup = (): void => { const cleanup = (): void => {
if (timeoutId) { if (timeoutId) {