github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: unflake cookie test on windows (#3489)

Browse Source
This commit is contained in:
Andrey Lushnikov 2018-11-02 13:23:44 -07:00 committed by GitHub
parent 60a8d4115d
commit 6b65407ab6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
test/headful.spec.js
View File

@ -17,8 +17,8 @@
const path = require('path'); const path = require('path');
const os = require('os'); const os = require('os');
const fs = require('fs'); const fs = require('fs');
const rm = require('rimraf').sync;
const {helper} = require('../lib/helper'); const {helper} = require('../lib/helper');
const rmAsync = helper.promisify(require('rimraf'));
const utils = require('./utils'); const utils = require('./utils');
const {waitEvent} = utils; const {waitEvent} = utils;
const puppeteer = utils.requireRoot('index.js'); const puppeteer = utils.requireRoot('index.js');
@ -97,7 +97,8 @@ module.exports.addTests = function({testRunner, expect, defaultBrowserOptions})
await headlessPage.goto(server.EMPTY_PAGE); await headlessPage.goto(server.EMPTY_PAGE);
const cookie = await headlessPage.evaluate(() => document.cookie); const cookie = await headlessPage.evaluate(() => document.cookie);
await headlessBrowser.close(); await headlessBrowser.close();
rm(userDataDir); // This might throw. See https://github.com/GoogleChrome/puppeteer/issues/2778
await rmAsync(userDataDir).catch(e => {});
expect(cookie).toBe('foo=true'); expect(cookie).toBe('foo=true');
}); });
it('OOPIF: should report google.com frame', async({server}) => { it('OOPIF: should report google.com frame', async({server}) => {